Go To Definition: Automatically navigate to user code when multiple locations include generated code by Copilot · Pull Request #80669 · dotnet/roslyn

Copilot · 2025-10-12T13:25:53Z

Plan: Improve Go To Definition to prefer user code over generated code

Original prompt

This section details on the original issue you should resolve

<issue_title>Go To Definition should not require tool window to decide between user code and generated code</issue_title>
<issue_description>## Summary

When the Go To Definition command encounters a type reference whose type declaration is split across multiple locations, but only one location lies within user code, jump to that location without prompting the user.

Background and Motivation

With the proliferation of source generators, which dictate partial types, Go To Definition on a reference to a user type no longer jumps to the user's definition of the type, but rather opens a tool window that shows the user's one file and one or more source generated code files. The user then has to choose their user code file before the IDE will jump to their type declaration.

This is a pain, since 99-100% of the time I want to jump to my own code declaration, as the source generated code is largely invisible and irrelevant to my work. I don't want a tool window to interact with. Just jump to my definition!

Proposed Feature

When Go To Definition has multiple locations it might navigate to, only ask the user which one they want if there are multiple non-source generated files that are candidate targets.

Alternative Designs

Craft a new attribute (with [Conditional(false)] and AllowMultiple=true on it, that source generators can emit on partial declarations that can act as a clue to GTD to indicate that users are unlikely to care about it.
Maybe some source generators emit partials that are more often interesting for users to look at. Allowing the source generators to indicate (with an attribute) the likelihood of this happening can help the GTD command prompt when the user would likely see value there, and skip the prompt otherwise.</issue_description>

<agent_instructions>This one is tricky, but doable. What we likely want here is to augment GetStreamingLocationAsync such that if it finds multiple locations, it continues to show the window with all the results, but it also navigates to the first item that comes from a Document for whom IsGeneratedCodeAsync is false.

THis way the user can see all the results and navigate between them. But they get taken to the likely location they want. </agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes #77895

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Modified GetStreamingLocationAsync to automatically navigate to the first non-generated code location when multiple definition locations exist, while still showing all results in the tool window. This improves the user experience when dealing with partial types that have both user code and source-generated code. Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>

Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>

CyrusNajmabadi · 2025-10-12T13:49:39Z

src/EditorFeatures/Core/Host/IStreamingFindReferencesPresenter.cs

+                var document = sourceSpan.Document;
+
+                // Check if this document is generated code
+                var generatedCodeService = document.GetLanguageService<IGeneratedCodeRecognitionService>();


@copilot use the existing IsGeneratedCodeAsync extension. You don't need to directly access this service. You will also not need any sort of null check.

Updated to use the IsGeneratedCodeAsync extension method and removed the unnecessary service access and null check. Commit: HEAD

Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>

CyrusNajmabadi · 2025-10-12T14:11:36Z

src/EditorFeatures/Core/Host/IStreamingFindReferencesPresenter.cs

+        ArrayBuilder<(DefinitionItem item, INavigableLocation location)> builder,
+        CancellationToken cancellationToken)
+    {
+        // Look through all definition items to find the first one that comes from a non-generated document


@copilot remove all the comments inside this method. they're very redundant.

Removed all inline comments from the method. Commit: HEAD

CyrusNajmabadi · 2025-10-12T14:11:51Z

src/EditorFeatures/Core/Host/IStreamingFindReferencesPresenter.cs

+            // Check each source span in the definition item
+            foreach (var sourceSpan in item.SourceSpans)
+            {
+                var document = sourceSpan.Document;


@copilot inline this local variable.

Inlined the local variable. Commit: HEAD

CyrusNajmabadi · 2025-10-12T14:12:02Z

src/EditorFeatures/Core/Host/IStreamingFindReferencesPresenter.cs

+                {
+                    // Found a non-generated location, return it
+                    return location;
+                }


@copilot remove these braces.

CyrusNajmabadi · 2025-10-12T14:12:13Z

src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpSourceGenerators.cs

        Assert.Equal(HelloWorldGenerator.GeneratedFolderClassName, await TestServices.Editor.GetSelectedTextAsync(HangMitigatingCancellationToken));
    }
+
+    [IdeFact]


@copilot add WorkItem attribute here.

Added WorkItem attribute for issue #77895. Commit: HEAD

CyrusNajmabadi · 2025-10-12T14:12:31Z

src/EditorFeatures/Core/Host/IStreamingFindReferencesPresenter.cs

 // See the LICENSE file in the project root for more information.

 using System.Collections.Immutable;
+using System.Linq;


@copilot was this using directive needed?

No, it was not needed. SelectAsArray is from PooledObjects, not System.Linq. Removed. Commit: HEAD

…nAsync Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>

…dd WorkItem Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>

Initial plan

a284d34

Copilot AI assigned Copilot and CyrusNajmabadi Oct 12, 2025

Copilot started work on behalf of CyrusNajmabadi October 12, 2025 13:26 View session

Copilot AI and others added 2 commits October 12, 2025 13:34

Add test for Go To Definition with partial user and generated code

f08c0e4

Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix Go To Definition to jump directly to user code~~ Go To Definition: Automatically navigate to user code when multiple locations include generated code Oct 12, 2025

Copilot AI requested a review from CyrusNajmabadi October 12, 2025 13:45

Copilot finished work on behalf of CyrusNajmabadi October 12, 2025 13:45

CyrusNajmabadi reviewed Oct 12, 2025

View reviewed changes

Copilot started work on behalf of CyrusNajmabadi October 12, 2025 13:50 View session

Use IsGeneratedCodeAsync extension method to simplify code

e5822ae

Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>

Copilot AI requested a review from CyrusNajmabadi October 12, 2025 13:56

Copilot finished work on behalf of CyrusNajmabadi October 12, 2025 13:56

CyrusNajmabadi reviewed Oct 12, 2025

View reviewed changes

Copilot started work on behalf of CyrusNajmabadi October 12, 2025 14:11 View session

CyrusNajmabadi reviewed Oct 12, 2025

View reviewed changes

Remove redundant inline comments from GetPreferredNonGeneratedLocatio…

38d00fa

…nAsync Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>

CyrusNajmabadi approved these changes Oct 12, 2025

View reviewed changes

CyrusNajmabadi marked this pull request as ready for review October 12, 2025 14:16

CyrusNajmabadi requested a review from a team as a code owner October 12, 2025 14:16

Copilot AI requested a review from CyrusNajmabadi October 12, 2025 14:16

Copilot finished work on behalf of CyrusNajmabadi October 12, 2025 14:16

Copilot started work on behalf of CyrusNajmabadi October 12, 2025 14:17 View session

Address code review feedback: inline variable, remove unused using, a…

eff2450

…dd WorkItem Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>

Copilot finished work on behalf of CyrusNajmabadi October 12, 2025 14:23

build-analysis bot mentioned this pull request Oct 12, 2025

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

3 tasks

CyrusNajmabadi added 3 commits October 13, 2025 01:21

Add using

6e17394

remove

e8a0513

Update tests

dad6aba

JoeRobich approved these changes Oct 13, 2025

View reviewed changes

CyrusNajmabadi merged commit 3a0fb03 into main Oct 13, 2025
25 checks passed

CyrusNajmabadi deleted the copilot/fix-go-to-definition-tool-window branch October 13, 2025 17:10

dotnet-policy-service bot added this to the Next milestone Oct 13, 2025

peterwald mentioned this pull request Oct 14, 2025

Revert "Go To Definition: Automatically navigate to user code when multiple locations include generated code" #80713

Merged

CyrusNajmabadi mentioned this pull request Oct 14, 2025

Compute if a doc is generated code or not in OOP not on the host #80715

Merged

davidwengier modified the milestones: Next, 18.3 Jan 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Go To Definition: Automatically navigate to user code when multiple locations include generated code#80669

Go To Definition: Automatically navigate to user code when multiple locations include generated code#80669
CyrusNajmabadi merged 9 commits intomainfrom
copilot/fix-go-to-definition-tool-window

Copilot AI commented Oct 12, 2025 •

edited

Loading

Uh oh!

CyrusNajmabadi Oct 12, 2025

Uh oh!

Copilot AI Oct 12, 2025

Uh oh!

CyrusNajmabadi Oct 12, 2025

Uh oh!

Copilot AI Oct 12, 2025

Uh oh!

CyrusNajmabadi Oct 12, 2025

Uh oh!

Copilot AI Oct 12, 2025

Uh oh!

CyrusNajmabadi Oct 12, 2025

Uh oh!

CyrusNajmabadi Oct 12, 2025

Uh oh!

Copilot AI Oct 12, 2025

Uh oh!

CyrusNajmabadi Oct 12, 2025

Uh oh!

Copilot AI Oct 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Copilot AI commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Plan: Improve Go To Definition to prefer user code over generated code

Background and Motivation

Proposed Feature

Alternative Designs

Comments on the Issue (you are @copilot in this section)

Uh oh!

CyrusNajmabadi Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

CyrusNajmabadi Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

CyrusNajmabadi Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

CyrusNajmabadi Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

CyrusNajmabadi Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

CyrusNajmabadi Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Oct 12, 2025 •

edited

Loading