Do not run the 'fully qualify' fixer on sourcce-generated docs#80649
Do not run the 'fully qualify' fixer on sourcce-generated docs#80649CyrusNajmabadi merged 1 commit intodotnet:mainfrom
Conversation
| // Don't bother executing this within a source-generated document. Changing the code here isn't actually | ||
| // possible, and we don't need to make pointless calls to oop to compute things. | ||
| if (document.Id.IsSourceGenerated) | ||
| return; |
There was a problem hiding this comment.
this fixer is fairly special as it has its own remote service that it calls into. this was crashing as the remote service was not expecting to be called ona source-generated doc. simplest fix is to just disable ourselves there since we can't offer anything useful anyways.
There was a problem hiding this comment.
Can I convince you to special case document.IsRazorSourceGeneratedDocument() here? We won't hit the crash, see convo: https://teams.microsoft.com/l/message/19:880daa5569e3460eadcae690247f1402@thread.skype/1760139419054?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=4ba7372f-2799-4677-89f0-7a1aaea3706c&parentMessageId=1760137684393&teamName=.NET%20Developer%20Experience&channelName=IDE&createdTime=1760139419054
Fixes a crash reported by a customer on discord: https://discord.com/channels/143867839282020352/598678594750775301/1426300473933299794
Fixes #80099