Use proper "unsafe" context while binding type in explicit interface specifier#80610
Merged
AlekseyTs merged 2 commits intodotnet:mainfrom Oct 13, 2025
Merged
Use proper "unsafe" context while binding type in explicit interface specifier#80610AlekseyTs merged 2 commits intodotnet:mainfrom
AlekseyTs merged 2 commits intodotnet:mainfrom
Conversation
333fred
reviewed
Oct 9, 2025
|
|
||
| class PointerImpl : IPointerTest | ||
| { | ||
| unsafe void ITest<void*[]>.Method() |
Member
There was a problem hiding this comment.
Are there any tests without unsafe here verifying we report an error?
Contributor
Author
There was a problem hiding this comment.
Are there any tests without
unsafehere verifying we report an error?
Probably. It was easier for me to add new ones.
Open
3 tasks
333fred
approved these changes
Oct 10, 2025
Contributor
Author
|
@dotnet/roslyn-compiler For a second review |
jjonescz
approved these changes
Oct 13, 2025
| comp.VerifyDiagnostics(); | ||
| } | ||
|
|
||
| [Fact] |
Member
There was a problem hiding this comment.
Consider adding WorkItem attribute
This was referenced Oct 17, 2025
This was referenced Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80565.