PEDeltaAssemblyBuilder: Don't freeze _needsGeneratedAttributes compilation state.#80600
PEDeltaAssemblyBuilder: Don't freeze _needsGeneratedAttributes compilation state.#80600AlekseyTs merged 1 commit intodotnet:mainfrom
_needsGeneratedAttributes compilation state.#80600Conversation
…ilation state. Related to dotnet#80405.
| private EmbeddableAttributes GetNeedsGeneratedAttributesInternal() | ||
| { | ||
| return (EmbeddableAttributes)_needsGeneratedAttributes | Compilation.GetNeedsGeneratedAttributes(); | ||
| return (EmbeddableAttributes)_needsGeneratedAttributes | Compilation.GetNeedsGeneratedAttributes(freezeState: this is not PEDeltaAssemblyBuilder); |
There was a problem hiding this comment.
Why do we have the freezing in the first place? Aren't we opening other bugs if we skip it?
There was a problem hiding this comment.
Why do we have the freezing in the first place? Aren't we opening other bugs if we skip it?
It is true that we are potentially opening ourselves to other negative consequences. But, apparently, Edit-And-Continue "likes" to live dangerously and is willing to accept a potential instability in exchange for immediate performance gains.
|
Let's add a test that hits this. I'll be able to look into it next week. |
Per offline discussion, I am going to merge this PR without the test. The original issue will remain open and will track the follow up work. |
Related to #80405.