Disable CS8002 warning when targeting .NET Core by Copilot · Pull Request #80596 · dotnet/roslyn

Copilot · 2025-10-08T18:27:29Z

Add CS8002 suppression to Microsoft.CSharp.Core.targets for .NETCoreApp
Add CS8002 suppression to Microsoft.VisualBasic.Core.targets for .NETCoreApp
Add tests to verify target files can be imported for different frameworks
Update comment text to be more specific about why CS8002 is not relevant
Convert test code snippets to use raw string literals (""")
Rename tests and add documentation about expected behavior for NoWarn property
Rename suppressStrongName to expectStrongNameSuppression in test methods
Build and test the changes - all tests pass

Original prompt

This section details on the original issue you should resolve

<issue_title>Disable CS8002 when targeting .NET Core</issue_title>
<issue_description>The warning CS8002 is not relevant when targeting .NET core and should be disabled. This needs to be done at the MSBuild level because that understands target frameworks while the compiler does not. Specifically the Microsoft.CSharp.Core.targets and Microsoft.VisualBasic.Core.targets files should be updated to include <NoWarn>$(NoWarn);8002</NoWarn> when the MSBuild property TargetFrameworkIdentifier is .NETCoreApp.

This should look similar to and be placed next to existing <NoWarn> suppressions for target frameworks. Example being here

roslyn/src/Compilers/Core/MSBuildTask/Microsoft.CSharp.Core.targets

Lines 65 to 67 in adaf4f7

<PropertyGroup Condition="('$(TargetFrameworkVersion)' != 'v1.0') and ('$(TargetFrameworkVersion)' != 'v1.1')">

<NoWarn>$(NoWarn);1701;1702</NoWarn>

</PropertyGroup>

Note: this is a dupe of #76197</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #80595

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>

src/Compilers/Core/MSBuildTask/Microsoft.CSharp.Core.targets

src/Compilers/Core/MSBuildTask/Microsoft.VisualBasic.Core.targets

src/Compilers/Core/MSBuildTaskTests/TargetTests.cs

…ests Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>

src/Compilers/Core/MSBuildTask/Microsoft.VisualBasic.Core.targets

jaredpar · 2025-10-09T21:42:05Z

src/Tools/Replay/Replay.csproj

    <PackageReference Include="Mono.Options" />
    <PackageReference Include="MSBuild.StructuredLogger" />
    <PackageReference Include="Basic.CompilerLog.Util" />
+    <packageReference Include="MessagePack" VersionOverride="3.1.4" />


Basic.CompilerLog.Util uses the 3.x flavor of MessagePack. Cannot upgrade our core version so had to do a version override here.

eng/Packages.props

jaredpar · 2025-10-10T20:57:38Z

@dotnet/roslyn-compiler PTAL

RikkiGibson

Note that you do need to enable strong naming in a compilation, in order to get any warnings about references lacking strong naming. That means that people who get this warning have that setting enabled by some mechanism.

That said, there's nothing wrong with blocking the warning regardless due to lack of platform support in netcore.

RikkiGibson · 2025-10-10T21:14:07Z

src/Compilers/Core/MSBuildTaskTests/SdkIntegrationTests.cs

+    [InlineData("net6.0", true)]
+    [InlineData("netstandard2.0", false)]
+    [InlineData("net472", false)]
+    public void StrongNameWarningCSharp(string tfm, bool suppressStrongName)


I think suppressStrongName should be renamed to expectStrongNameSuppression to reflect its purpose (whether the tfm argument results in strong name warnings being suppressed.)

@copilot rename suppressStrongName to expectStrongNameSuppression

Renamed to expectStrongNameSuppression in commit that will be pushed.

src/Tools/Replay/Replay.csproj

RikkiGibson · 2025-10-10T21:15:45Z

src/Compilers/Core/MSBuildTaskTests/SdkIntegrationTests.cs

+    [InlineData("net6.0", true)]
+    [InlineData("netstandard2.0", false)]
+    [InlineData("net472", false)]
+    public void StrongNameWarningVisualBasic(string tfm, bool suppressStrongName)


Suggest doing the same rename here.

@copilot rename suppressStrongName to expectStrongNameSuppression

Renamed to expectStrongNameSuppression in commit that will be pushed.

Co-authored-by: Rikki Gibson <rigibson@microsoft.com>

…ationTests Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>

Initial plan

ece527e

Copilot AI assigned Copilot and jaredpar Oct 8, 2025

Copilot started work on behalf of jaredpar October 8, 2025 18:27 View session

Copilot AI and others added 2 commits October 8, 2025 18:43

Add CS8002 suppression for .NETCoreApp in MSBuild targets

99c010f

Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>

Add tests for target file imports with different frameworks

6fe6c20

Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Disable CS8002 warning when targeting .NET Core~~ Disable CS8002 warning when targeting .NET Core Oct 8, 2025

Copilot AI requested a review from jaredpar October 8, 2025 18:49

Copilot finished work on behalf of jaredpar October 8, 2025 18:49

jaredpar reviewed Oct 8, 2025

View reviewed changes

Copilot started work on behalf of jaredpar October 8, 2025 23:57 View session

Address PR feedback: update comments and use raw string literals in t…

da4da95

…ests Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>

Copilot finished work on behalf of jaredpar October 9, 2025 00:05

Copilot AI requested a review from jaredpar October 9, 2025 00:05

svick reviewed Oct 9, 2025

View reviewed changes

src/Compilers/Core/MSBuildTask/Microsoft.VisualBasic.Core.targets Outdated Show resolved Hide resolved

Copilot started work on behalf of jaredpar October 9, 2025 16:10 View session

Copilot finished work on behalf of jaredpar October 9, 2025 16:13

Cleanup tests

a90088a

jaredpar reviewed Oct 9, 2025

View reviewed changes

jaredpar added 2 commits October 9, 2025 15:01

Index and Range work

60cb2c6

Get test artifacts

b7114d3

jaredpar reviewed Oct 10, 2025

View reviewed changes

eng/Packages.props Outdated Show resolved Hide resolved

Apply suggestion from @jaredpar

93f5546

jaredpar approved these changes Oct 10, 2025

View reviewed changes

jaredpar marked this pull request as ready for review October 10, 2025 20:57

jaredpar requested review from a team as code owners October 10, 2025 20:57

RikkiGibson approved these changes Oct 10, 2025

View reviewed changes

Apply suggestion from @RikkiGibson

c9206eb

Co-authored-by: Rikki Gibson <rigibson@microsoft.com>

Copilot started work on behalf of jaredpar October 10, 2025 21:38 View session

Rename suppressStrongName to expectStrongNameSuppression in SdkIntegr…

3ab4879

…ationTests Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>

Copilot AI requested a review from jaredpar October 10, 2025 21:44

Copilot finished work on behalf of jaredpar October 10, 2025 21:44

JoeRobich approved these changes Oct 10, 2025

View reviewed changes

RikkiGibson approved these changes Oct 10, 2025

View reviewed changes

jaredpar enabled auto-merge (squash) October 10, 2025 22:09

jaredpar merged commit 6e00487 into main Oct 14, 2025
27 of 28 checks passed

dotnet-policy-service bot added this to the Next milestone Oct 14, 2025

jaredpar mentioned this pull request Oct 14, 2025

CS8002 Referenced assembly does not have a strong name triggers when it doesn't need to. #76197

Closed

dotnet-maestro bot mentioned this pull request Oct 15, 2025

[main] Source code updates from dotnet/roslyn dotnet/dotnet#2842

Closed

dotnet-bot mentioned this pull request Oct 17, 2025

[Automated] PRs inserted in VS build main-11116.18 #80790

Closed

dotnet-maestro bot mentioned this pull request Oct 17, 2025

[main] Source code updates from dotnet/roslyn dotnet/dotnet#2965

Closed

This was referenced Oct 17, 2025

[Automated] PRs inserted in VS build feature.polytype-11117.05 #80797

Closed

[Automated] PRs inserted in VS build feature.debugger.main-11116.247 #80798

Closed

[Automated] PRs inserted in VS build feature.polytype-11116.236 #80799

Closed

This was referenced Oct 23, 2025

[main] Source code updates from dotnet/roslyn dotnet/dotnet#3061

Closed

[main] Source code updates from dotnet/roslyn dotnet/dotnet#3147

Closed

jjonescz mentioned this pull request Nov 7, 2025

[release/10.0.2xx] Source code updates from dotnet/dotnet dotnet/sdk#51612

Merged

CyrusNajmabadi deleted the copilot/disable-cs8002-warning-dotnet-core branch December 2, 2025 11:53

dotnet-maestro bot mentioned this pull request Dec 18, 2025

[main] Source code updates from dotnet/roslyn dotnet/dotnet#3957

Merged

davidwengier modified the milestones: Next, 18.3 Jan 6, 2026

	<PropertyGroup Condition="('$(TargetFrameworkVersion)' != 'v1.0') and ('$(TargetFrameworkVersion)' != 'v1.1')">
	<NoWarn>$(NoWarn);1701;1702</NoWarn>
	</PropertyGroup>

Conversation

Copilot AI commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comments on the Issue (you are @copilot in this section)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jaredpar Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jaredpar commented Oct 10, 2025

Uh oh!

RikkiGibson left a comment

Choose a reason for hiding this comment

Uh oh!

RikkiGibson Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

jaredpar Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

RikkiGibson Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

jaredpar Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Copilot AI commented Oct 8, 2025 •

edited

Loading