Unskip tests of MSBuildWorkspace with blazor and blazorwasm templates#80468
Merged
jasonmalinowski merged 3 commits intodotnet:mainfrom Nov 10, 2025
Merged
Conversation
59b6dfe to
11c5ff7
Compare
This changes the condition to continue to skip them on 32-bit runs, which is the real reason they're broken.
bf999a4 to
b524bf5
Compare
jasonmalinowski
commented
Nov 8, 2025
| var project = await workspace.OpenProjectAsync(projectFilePath, cancellationToken: CancellationToken.None); | ||
|
|
||
| string binlogPath; | ||
| if (Environment.GetEnvironmentVariable("HELIX_DUMP_FOLDER") is string helixDumpFolder && !string.IsNullOrEmpty(helixDumpFolder)) |
Member
Author
There was a problem hiding this comment.
Once we move to xunit 3 we should switch this over to using the file attachment support. And then make sure whatever magic needs to happen for those to be auto-captured in Helix works.
jasonmalinowski
commented
Nov 8, 2025
Comment on lines
+236
to
+239
| var analyzerLoadDiagnostics = new List<AnalyzerLoadFailureEventArgs>(); | ||
|
|
||
| foreach (var analyzerReference in project.AnalyzerReferences.OfType<AnalyzerFileReference>()) | ||
| analyzerReference.AnalyzerLoadFailed += (sender, e) => analyzerLoadDiagnostics.Add(e); |
JoeRobich
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the condition to continue to skip them on 32-bit runs, which is the real reason they're broken.
Fixes #80263.