Extension block members do not have this parameter#80457
Merged
AlekseyTs merged 7 commits intodotnet:mainfrom Sep 29, 2025
Merged
Extension block members do not have this parameter#80457AlekseyTs merged 7 commits intodotnet:mainfrom
this parameter#80457AlekseyTs merged 7 commits intodotnet:mainfrom
Conversation
16 tasks
Contributor
Author
333fred
approved these changes
Sep 25, 2025
Contributor
Author
jjonescz
approved these changes
Sep 26, 2025
| static bool hasRefToRefStructThis(MethodSymbol? method) | ||
| { | ||
| return method?.TryGetThisParameter(out var thisParameter) == true && | ||
| return method?.TryGetThisParameter(out var thisParameter) == true && thisParameter is not null && |
Member
There was a problem hiding this comment.
Consider nullable-enabling TryGetThisParameter to catch these kinds of mistakes sooner in the future #Resolved
Contributor
Author
There was a problem hiding this comment.
Technically this wouldn't help because on this code path null result was unexpected before my change to the behavior of the API.
Contributor
Author
There was a problem hiding this comment.
Annotated TryGetThisParameter
jjonescz
approved these changes
Sep 26, 2025
Contributor
Author
|
@jcouv Please review |
jcouv
reviewed
Sep 29, 2025
| static bool hasRefToRefStructThis(MethodSymbol? method) | ||
| { | ||
| return method?.TryGetThisParameter(out var thisParameter) == true && | ||
| return method?.TryGetThisParameter(out var thisParameter) == true && thisParameter is not null && |
Member
There was a problem hiding this comment.
Should Never mind, I see we already have #ClosedBinder.HasThis(...) method be adjusted as well?
jcouv
approved these changes
Sep 29, 2025
This was referenced Oct 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #78968
Relates to test plan #76130