Skip to content

Enable runtime async tests#80362

Merged
333fred merged 15 commits intodotnet:mainfrom
333fred:test-runtime-async
Nov 4, 2025
Merged

Enable runtime async tests#80362
333fred merged 15 commits intodotnet:mainfrom
333fred:test-runtime-async

Conversation

@333fred
Copy link
Member

@333fred 333fred commented Sep 18, 2025

Enables runtime async tests, both locally (when DOTNET_RuntimeAsync=1 is set on the command line, or using the --testRuntimeAsync flag is passed to ./build.(sh|ps1)), and in CI in a new, dedicated leg. Closes #79791.

Relates to test plan #75960

There are plenty of crashes to work through here, will need to spend some time doing so.
* upstream/main: (31 commits)
  Remove bogus xlf tag (dotnet#80357)
  Fix missing type argument checks
  Add tests
  Use dotnet run file for generating compiler code (dotnet#80248)
  Only restore based on assets file changes if the actual content changed (dotnet#80341)
  make expressionbody analyzer use semanticspananalysis (dotnet#80339)
  [EnC] Use ignoreAssemblyKey: false to resolve symbol keys (dotnet#80342)
  Properly populate ExportedType metadata table in presence of extension block. (dotnet#80311)
  Propagate `params` to lambdas and local functions (dotnet#79880)
  Change 17.15 to VS 2026 preview. (dotnet#80325)
  Improve virtualproject support for older .NET SDKs (dotnet#80324)
  Update dependencies from https://github.com/dotnet/dotnet build 283666 (dotnet#80344)
  Update dependencies from https://github.com/dotnet/arcade build 20250917.6 (dotnet#80343)
  Simplifying
  Fix tests
  Fix tests
  Fix introduce variable placement in top level statements
  move to immutable types in signature help
  move to immutable types in signature help
  Fix check
  ...
* upstream/main: (252 commits)
  Move Watch EA to a separate assembly Microsoft.CodeAnalysis.ExternalAccess.HotReload (dotnet#80556)
  Enable long paths for Windows DartLab CI (dotnet#80581)
  Ensure that CS8659 is reported on partial properties (dotnet#80573)
  Fix a wrong relative link in a doc (dotnet#80567)
  [main] Source code updates from dotnet/dotnet (dotnet#80578)
  Update dependencies from https://github.com/dotnet/arcade build 20251006.2 (dotnet#80577)
  Update main configs after VS snap (dotnet#80523)
  Add followup async public apis (dotnet#80455)
  Reduce allocations in CSharpSyntaxNode.GetStructure (dotnet#80562)
  Extensions: Close some tracked follow-ups (dotnet#80527)
  Fix outdated 17.15 to 18.0 (dotnet#80570)
  Update dependencies from https://github.com/dotnet/dotnet build 285582 (dotnet#80551)
  Fix all-in-one tests
  [main] Update dependencies from dotnet/arcade (dotnet#80559)
  Improve error recovery when object initializer uses ':' instead of '=' (dotnet#80553)
  Support `field` keyword in EE. (dotnet#80515)
  Log a debug message for ContentModified exceptions. (dotnet#80549)
  Update dependencies from https://github.com/dotnet/arcade build 20251002.2 (dotnet#80550)
  Fix
  Simplify and add additional asserts
  ...
* upstream/main: (332 commits)
  Cache lambdas in analyzer driver (dotnet#80759)
  Add information for NuGet package version 4.14 (dotnet#80870)
  Add missing search keywords to VB Advanced options page
  Fix IDE0031 false positive when preprocessor directives are used in if statements (dotnet#80878)
  Use core compiler on netfx hosts with toolset package (dotnet#80631)
  Make string concat assert more precise (dotnet#80619)
  Extensions: address some diagnostic quality issues (dotnet#80827)
  Add note on traversal order for bound nodes (dotnet#80872)
  Ensure that locals at the top level of a constructor have the same safe-context as parameters (dotnet#80807)
  Fix handling of SymbolDisplayCompilerInternalOptions.UseArityForGenericTypes option for non-native symbol implementations (dotnet#80826)
  Update src/Analyzers/CSharp/Tests/UseCollectionInitializer/UseCollectionInitializerTests.cs
  Add IsValidContainingStatement check to prevent collection initializers in using declarations
  Add back old DocumentSpan constructor (dotnet#80864)
  Add tests verifying pointer types in type parameters require unsafe context (dotnet#80776)
  Add regression test for Interlocked.Exchange with nullable types (dotnet#80796)
  Add regression test for ParseAttributeArgumentList with invalid input (fixes dotnet#8699) (dotnet#80705)
  Add regression test for compiler crash with syntax error in indexer declaration (dotnet#80772)
  Add runtime NullReferenceException validation to foreach null iteration tests (dotnet#80839)
  Update MicrosoftBuildTasksCoreVersionForMetrics to 17.11.48 (dotnet#80812)
  Mark CS4009 error as a "build only" error. (dotnet#80698)
  ...
@333fred 333fred changed the title Start of enabling runtime async tests Enable runtime async tests Oct 24, 2025
@333fred 333fred marked this pull request as ready for review October 27, 2025 21:58
@333fred 333fred requested review from a team as code owners October 27, 2025 21:58
@333fred
Copy link
Member Author

333fred commented Oct 27, 2025

@dotnet/roslyn-compiler for review.

Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with review pass (commit 14)

Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (commit 15)

@333fred
Copy link
Member Author

333fred commented Oct 28, 2025

@dotnet/roslyn-compiler for a second review.

Copy link
Contributor

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off. I didn't examine any of the infra changes.

@333fred
Copy link
Member Author

333fred commented Nov 4, 2025

/azp run roslyn-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@333fred
Copy link
Member Author

333fred commented Nov 4, 2025

Rerunning the tests since it's been a week and I want to make sure nothing broke in the meantime.

@333fred 333fred enabled auto-merge (squash) November 4, 2025 00:25
@333fred 333fred merged commit dfef4c1 into dotnet:main Nov 4, 2025
28 of 29 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 4, 2025
@333fred 333fred deleted the test-runtime-async branch November 4, 2025 03:09
@davidwengier davidwengier modified the milestones: Next, 18.3 Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verify runtime execution of runtime async tests

5 participants