Temporarily re-add ITypeSymbol extension APIs#80279
Closed
jjonescz wants to merge 1 commit intodotnet:mainfrom
Closed
Temporarily re-add ITypeSymbol extension APIs#80279jjonescz wants to merge 1 commit intodotnet:mainfrom
jjonescz wants to merge 1 commit intodotnet:mainfrom
Conversation
Contributor
|
This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging. |
CyrusNajmabadi
approved these changes
Sep 15, 2025
Member
Author
|
Thanks for reviews, I'm planning to close this and apply the changes directly to the VMR in dotnet/dotnet#2420 for expediency (and also to verify it really fixes the issue there). |
jcouv
reviewed
Sep 15, 2025
| /// </summary> | ||
| bool IsNativeIntegerType { get; } | ||
|
|
||
| [Obsolete($"This API will be removed in the future. Use {nameof(INamedTypeSymbol)}.{nameof(INamedTypeSymbol.IsExtension)} instead.")] |
Member
There was a problem hiding this comment.
Will Obsolete cause problems in the Source Build?
Member
Author
There was a problem hiding this comment.
It should not. The analyzer is built against an old version of roslyn which doesn't have the Obsolete attribute. The same analyzer then runs against a new version of roslyn so it needs the API to be available at runtime only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source build is currently blocked (see dotnet/dotnet#2276 (comment)) because ILLink analyzer which lives in runtime is compiled against rc1 roslyn (which has the extension APIs on ITypeSymbol). Then winforms repo is compiled in source build, using the just-built ILLink analyzer but against the latest roslyn, hence failing with MissingMethodException (because the API on ITypeSymbol doesn't exist).
Temporarily re-adding the APIs is the simplest solution to unblock the flow I think.