Fix results streamed by ForAttributeWithMetadataName with multiple parts#79947
Merged
CyrusNajmabadi merged 4 commits intodotnet:mainfrom Aug 19, 2025
Merged
Fix results streamed by ForAttributeWithMetadataName with multiple parts#79947CyrusNajmabadi merged 4 commits intodotnet:mainfrom
CyrusNajmabadi merged 4 commits intodotnet:mainfrom
Conversation
Contributor
Author
|
@dotnet/roslyn-compiler @RikkiGibson ptal. |
chsienki
approved these changes
Aug 18, 2025
RikkiGibson
approved these changes
Aug 18, 2025
RikkiGibson
reviewed
Aug 18, 2025
|
|
||
| public override SyntaxNode RemapAttributeTarget(SyntaxNode target) | ||
| { | ||
| return target is VariableDeclaratorSyntax { Parent: VariableDeclarationSyntax { Parent: BaseFieldDeclarationSyntax baseField } } |
Member
There was a problem hiding this comment.
Main thing I would want to make sure of is: are we sure that this is the only special case we need to handle? e.g. there's no other symbol kind, where the syntax which is considered to declare the symbol, isn't actually the target of the attributes in syntax, and some parent node is instead.
Contributor
Author
There was a problem hiding this comment.
so, as part of the original work, we tested all cases where attributes can appear. so all of those exercised these codepaths.
Open
3 tasks
This was referenced Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79519