Reenable/Fix integration test reporting#79789
Merged
dibarbet merged 2 commits intodotnet:mainfrom Aug 12, 2025
Merged
Conversation
d13c6ff to
6fede59
Compare
Also fix newly failing tests
6fede59 to
398c879
Compare
dibarbet
commented
Aug 11, 2025
| private void LoadLanguageClient() | ||
| { | ||
| using var token = _asynchronousOperationListener.BeginAsyncOperation(nameof(LoadLanguageClient)); | ||
| var token = _asynchronousOperationListener.BeginAsyncOperation(nameof(LoadLanguageClient)); |
Member
Author
There was a problem hiding this comment.
fixes double dispose exception I saw debugging the integration tests
JoeRobich
reviewed
Aug 11, 2025
src/EditorFeatures/Core/LanguageServer/AlwaysActiveLanguageClientEventListener.cs
Show resolved
Hide resolved
3 tasks
dibarbet
commented
Aug 12, 2025
| await TestServices.Shell.ExecuteCommandAsync(VSConstants.VSStd2KCmdID.ToggleConsumeFirstCompletionMode, cancellationToken); | ||
| if (await IsUseSuggestionModeOnAsync(forDebuggerTextView, cancellationToken) != value) | ||
| await UpdateUseSuggestionModeAsync(); | ||
| var useSuggestionMode = await IsUseSuggestionModeOnAsync(forDebuggerTextView, cancellationToken); |
Member
Author
There was a problem hiding this comment.
These test started failing to set the option when resetting options between tests. Talked to the editor - the olecommand version only works with an active text view which we may not have at that point.
Instead we can just use the editor API to set the option, like we do when we read it.
JoeRobich
approved these changes
Aug 12, 2025
This was referenced Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry logic broke when we updated the test runner. This caused tests that failed to never get reported as failed if they were retried.
Fix was made in the extension testing library, also updated tests to fix new failures.