Fix not offering to remove unnecessary nullable pragmas#79356
Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom Jul 14, 2025
Merged
Fix not offering to remove unnecessary nullable pragmas#79356CyrusNajmabadi merged 1 commit intodotnet:mainfrom
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
Conversation
| } | ||
|
|
||
| // An attribute name cannot itself be nullable. `[CLSCompliant?]` is not a thing. | ||
| if (node.IsParentKind(SyntaxKind.Attribute)) |
Contributor
There was a problem hiding this comment.
An attribute can have a constructor parameter/property initializer, which can lead to warnings after nullable directive removed, e.g. [MyAttr(null, Prop = null)] with MyAttr declared as
#nullable enable
class MyAttr : Attribute
{
public object Prop { get; set; }
public MyAttr(string s) { }
}Does this change account for that? Add test cases for this
AbhitejJohn
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65401