Use raw strings in tests#79305
Merged
CyrusNajmabadi merged 6 commits intodotnet:mainfrom Jul 10, 2025
Merged
Conversation
8a6d283 to
10bfecb
Compare
e5aab0b to
292e0ea
Compare
02136a9 to
52540ea
Compare
52540ea to
ad2eb92
Compare
JoeRobich
reviewed
Jul 9, 2025
| // Field | ||
| [InlineData(@"Scope = ""member""", @"Target = ""~F:N.C.F""", "assembly")] | ||
| [InlineData(""" | ||
| Scope = "member" |
Member
There was a problem hiding this comment.
nit: This feels a bit verbose just to avoid escaping the double quotes, but I could live with it.
Contributor
Author
There was a problem hiding this comment.
i think it's a matter of perspective. It def increases the number of lines, in the case where there are escaped quotes at teh start/end of the string. But it think it's much clearer to just have 'the raw contents' which i don't have to interpret.
JoeRobich
reviewed
Jul 9, 2025
| XmlDoc.AttributeName("langword"), | ||
| XmlDoc.Delimiter("="), | ||
| XmlDoc.AttributeQuotes("\""), | ||
| XmlDoc.AttributeQuotes(""" |
Member
There was a problem hiding this comment.
I feel like the current version of this is easier to read.
JoeRobich
reviewed
Jul 9, 2025
src/EditorFeatures/CSharpTest/CodeActions/InitializeParameter/AddParameterCheckTests.cs
Outdated
Show resolved
Hide resolved
494203f to
1b48939
Compare
f73caeb to
c64a70e
Compare
96eb88c to
da97049
Compare
da97049 to
1c3b871
Compare
JoeRobich
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.