Remove duplicate code for processing arrays vs strings#79233
Merged
CyrusNajmabadi merged 17 commits intodotnet:mainfrom Jul 9, 2025
Merged
Remove duplicate code for processing arrays vs strings#79233CyrusNajmabadi merged 17 commits intodotnet:mainfrom
CyrusNajmabadi merged 17 commits intodotnet:mainfrom
Conversation
CyrusNajmabadi
commented
Jul 2, 2025
RikkiGibson
reviewed
Jul 3, 2025
Contributor
Author
|
@dotnet/roslyn-compiler this is ready for review. |
jjonescz
approved these changes
Jul 7, 2025
RikkiGibson
requested changes
Jul 7, 2025
Member
RikkiGibson
left a comment
There was a problem hiding this comment.
everything LGTM but want to get the insertion unblocked first and ideally a test insertion for this as it seems this area has been very sensitive to changes.
Contributor
Author
SGTM> |
Member
|
@dibarbet for visibility |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #79232
With the spannificaiton of most low level char-segment handling routines, we can now just have the string paths directly call into those routines with spans.