Update progression work to have context menu.#78754
Merged
CyrusNajmabadi merged 27 commits intodotnet:mainfrom May 30, 2025
Merged
Update progression work to have context menu.#78754CyrusNajmabadi merged 27 commits intodotnet:mainfrom
CyrusNajmabadi merged 27 commits intodotnet:mainfrom
Conversation
4 tasks
CyrusNajmabadi
commented
May 30, 2025
dibarbet
approved these changes
May 30, 2025
Member
dibarbet
left a comment
There was a problem hiding this comment.
the command bits are a mystery to me
| <Parent guid="guidRoslynGrpId" id="cmdidAnalyzerFolderContextMenu"/> | ||
| </Group> | ||
|
|
||
| <Group guid="guidRoslynGrpId" id="grpSolutionExplorerSymbolItemContextMenu" priority="0x000"> |
Member
There was a problem hiding this comment.
I have no idea if what is in here is correct - def need someone else to take a look at this (if anyone does)
Contributor
Author
There was a problem hiding this comment.
yeah. this was done with Jason/Joey yesterday. It's black magic to me as well :)
| <Strings> | ||
| <ButtonText>Clear</ButtonText> | ||
| <CommandName>CleearStackTraceExplorerCommandName</CommandName> | ||
| <CommandName>ClearStackTraceExplorerCommandName</CommandName> |
Member
There was a problem hiding this comment.
I assume renaming this won't potentially break something else? Are these visible to other components in VS?
|
|
||
| var guidContextMenu = Guids.RoslynGroupId; | ||
| if (Shell.Package.GetGlobalService(typeof(SVsUIShell)) is not IVsUIShell shell) | ||
| return false; |
Member
There was a problem hiding this comment.
is this ever not true? should this throw? (no clue)
Contributor
Author
There was a problem hiding this comment.
yeah. it likely will always be true... i'm just copying code from elsewhere :'(
src/VisualStudio/Core/Impl/SolutionExplorer/SymbolTree/SymbolItemContextMenuController.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: David Barbet <dibarbet@gmail.com>
…temContextMenuController.cs Co-authored-by: David Barbet <dibarbet@gmail.com>
This was referenced Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.