For IsAtDotDotToken, ensure the current token is a DotToken before parsing the next token to see if it's also a DotToken.#78338
Merged
ToddGrun merged 1 commit intodotnet:mainfrom Apr 28, 2025
Conversation
…rsing the next token to see if it's also a DotToken. I see LanguageParser.IsAtDotToken accounting for about 1 second of CPU time (0.5%) in the C# editing speedometer test. Local testing indicates about 85% of calls into this method will be filtered by this check. Going to initiate a speedometer run via a tes insertion and will update with the results when available.
jjonescz
approved these changes
Apr 28, 2025
This was referenced Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see LanguageParser.IsAtDotToken accounting for about 1 second of CPU time (0.5%) in the C# editing speedometer test. Local testing indicates about 85% of calls into this method will be filtered by this check.
Test insertion: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/631973
Speedometer results look good:
*** Old allocations under IsAtDotDotToken ***
*** Old CPU under IsAtDotDotToken ***
*** New allocations under IsAtDotDotToken ***
*** New CPU under IsAtDotDotToken ***
