Skip to content

[main] Source code updates from dotnet/dotnet#78309

Merged
ViktorHofer merged 4 commits intomainfrom
darc-main-95dc0414-4319-4bae-a0fb-2d44e021c002
Apr 25, 2025
Merged

[main] Source code updates from dotnet/dotnet#78309
ViktorHofer merged 4 commits intomainfrom
darc-main-95dc0414-4319-4bae-a0fb-2d44e021c002

Conversation

@dotnet-maestro
Copy link
Contributor

Note

This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

Updated Dependencies

@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner April 24, 2025 23:01
@ghost ghost added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 24, 2025
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approve

@ViktorHofer ViktorHofer deleted the darc-main-95dc0414-4319-4bae-a0fb-2d44e021c002 branch April 25, 2025 05:09
@ViktorHofer ViktorHofer restored the darc-main-95dc0414-4319-4bae-a0fb-2d44e021c002 branch April 25, 2025 05:11
@ViktorHofer ViktorHofer reopened this Apr 25, 2025
@ViktorHofer ViktorHofer enabled auto-merge (squash) April 25, 2025 05:12
@ViktorHofer ViktorHofer force-pushed the darc-main-95dc0414-4319-4bae-a0fb-2d44e021c002 branch from 3b47707 to 8d486ed Compare April 25, 2025 05:24
@ViktorHofer ViktorHofer requested a review from a team as a code owner April 25, 2025 05:27
@ViktorHofer
Copy link
Member

ViktorHofer commented Apr 25, 2025

@MichaelSimons we are struggling here. How can we disable prebuilt detection for roslyn in this PR? Arcade 9 doesn't respect the ReportPrebuiltUsage property.

-->
<PropertyGroup>
<SystemCommandLineVersion>2.0.0-beta5.25210.1</SystemCommandLineVersion>
<SystemCommandLineVersion>2.0.0-beta5.25224.104</SystemCommandLineVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ominous

Copy link
Member

@ViktorHofer ViktorHofer Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we might revert this change. I believe we should flow command-line-api not via the VMR but externally via the existing subscription as it keeps its official build. Waiting for some additional input from others on Teams.

auto-merge was automatically disabled April 25, 2025 17:56

Pull request was closed

@ViktorHofer ViktorHofer deleted the darc-main-95dc0414-4319-4bae-a0fb-2d44e021c002 branch April 25, 2025 17:56
@ViktorHofer ViktorHofer restored the darc-main-95dc0414-4319-4bae-a0fb-2d44e021c002 branch April 25, 2025 18:03
@ViktorHofer ViktorHofer reopened this Apr 25, 2025
@ViktorHofer ViktorHofer enabled auto-merge (squash) April 25, 2025 18:04
@ViktorHofer ViktorHofer merged commit e8740a4 into main Apr 25, 2025
27 of 28 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 25, 2025
@ViktorHofer ViktorHofer deleted the darc-main-95dc0414-4319-4bae-a0fb-2d44e021c002 branch April 25, 2025 20:17
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants