Move feature-oriented helpers to appropriate location#77611
Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom Mar 14, 2025
Merged
Move feature-oriented helpers to appropriate location#77611CyrusNajmabadi merged 1 commit intodotnet:mainfrom
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
Conversation
CyrusNajmabadi
commented
Mar 14, 2025
| [ImportingConstructor] | ||
| [Obsolete(MefConstruction.ImportingConstructorMessage, error: true)] | ||
| public CSharpDocumentDifferenceService() | ||
| protected override bool IsContainedInMemberBody(SyntaxNode node, TextSpan span) |
Contributor
Author
There was a problem hiding this comment.
just a move from CSharpSynatxFacts.
CyrusNajmabadi
commented
Mar 14, 2025
| Public Sub New() | ||
| End Sub | ||
|
|
||
| Protected Overrides Function IsContainedInMemberBody(node As SyntaxNode, span As Text.TextSpan) As Boolean |
Contributor
Author
There was a problem hiding this comment.
just a move from VisualBasicSyntaxFacts
CyrusNajmabadi
commented
Mar 14, 2025
| // Violation. This is a feature level API. | ||
| bool ContainsInMemberBody([NotNullWhen(true)] SyntaxNode? node, TextSpan span); | ||
| // Violation. This is a feature level API. | ||
| TextSpan GetInactiveRegionSpanAroundPosition(SyntaxTree tree, int position, CancellationToken cancellationToken); |
Contributor
Author
There was a problem hiding this comment.
i've marked apis that currently violate the docs of ISyntaxFacts. i continually try to move things out when i run across them.
This was referenced Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISyntaxFacts is not a dumping ground for individual features to place their logic in a shared location. It is intended to supply a uniform way of talkign to VB/C# when both are identical in syntactic structure.