Skip to content

Filter down the list of files we need to examing when looking for a :base(...) call in find refs#77610

Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
CyrusNajmabadi:findRefsPerf
Mar 14, 2025
Merged

Filter down the list of files we need to examing when looking for a :base(...) call in find refs#77610
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
CyrusNajmabadi:findRefsPerf

Conversation

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

@CyrusNajmabadi CyrusNajmabadi commented Mar 14, 2025

Note: we already have tests for tehse scenarios. This just adds a speedup optimization to avoid looking at unnecessary files.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner March 14, 2025 19:33
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 14, 2025
@CyrusNajmabadi CyrusNajmabadi requested a review from ToddGrun March 14, 2025 19:38
Copy link
Copy Markdown
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 9a120ba into dotnet:main Mar 14, 2025
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the findRefsPerf branch March 14, 2025 20:54
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Mar 14, 2025
@jjonescz jjonescz modified the milestones: Next, 17.14 P3 Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants