Move NullAsynchronousOperationListenerProvider to source package#77187
Draft
tmat wants to merge 1 commit intodotnet:mainfrom
Draft
Move NullAsynchronousOperationListenerProvider to source package#77187tmat wants to merge 1 commit intodotnet:mainfrom
tmat wants to merge 1 commit intodotnet:mainfrom
Conversation
9c02540 to
64eb0f7
Compare
bf4b445 to
2e173a0
Compare
Member
Author
|
@dotnet/roslyn ptal |
jjonescz
reviewed
Feb 14, 2025
jasonmalinowski
approved these changes
Feb 15, 2025
Member
jasonmalinowski
left a comment
There was a problem hiding this comment.
Looks good; I didn't look in detail to see if any of the files that got a #nullable enable added were missing any ?.
src/Features/Core/Portable/Shared/TestHooks/Legacy/ListenerForwarders.cs
Show resolved
Hide resolved
dibarbet
reviewed
Apr 24, 2025
| @@ -0,0 +1,2 @@ | |||
| [*.cs] | |||
| generated_code = true No newline at end of file | |||
Member
There was a problem hiding this comment.
For the clasp source package, I specifically had issues with compiler documentation warnings as well
https://github.com/dotnet/roslyn/blob/main/src/LanguageServer/Microsoft.CommonLanguageServerProtocol.Framework/contentFiles/.editorconfig#L14C19-L14C25
Not sure if that should be included, or if there is a better way to disable it
This was referenced Apr 26, 2025
Closed
Merged
tmat
commented
May 28, 2025
| [SuppressMessage("Style", "VSTHRD200:Use \"Async\" suffix for async methods", Justification = "This is a Task wrapper, not an asynchronous method.")] | ||
| public static Task CompletesTrackingOperation(this Task task, IDisposable token) | ||
| { | ||
| if (token == null || token == EmptyAsyncToken.Instance) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: blocked by TypeScript