Fix syntax generation of explict checked operator from symbol#77102
Merged
CyrusNajmabadi merged 2 commits intodotnet:mainfrom Feb 10, 2025
Merged
Fix syntax generation of explict checked operator from symbol#77102CyrusNajmabadi merged 2 commits intodotnet:mainfrom
CyrusNajmabadi merged 2 commits intodotnet:mainfrom
Conversation
carlossanlop
reviewed
Feb 7, 2025
src/Workspaces/CSharpTest/CodeGeneration/SyntaxGeneratorTests.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/CSharpTest/CodeGeneration/SyntaxGeneratorTests.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
All right, this is fixed now. My bad for misunderstanding the original bug. I was fixing the syntax layer to accept the bad input that SyntaxGenerator was giving it, but the bug was in SyntaxGenerator. One thing I noticed -- SyntaxGenerator does not have an |
Member
Author
|
Ping @CyrusNajmabadi can you have another look? |
Contributor
carlossanlop
left a comment
There was a problem hiding this comment.
The changes look good to me but I'll defer to Cyrus to approve.
CyrusNajmabadi
approved these changes
Feb 10, 2025
Contributor
|
LGTM. Thanks! |
This was referenced Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #77101
cc @carlossanlop @333fred @CyrusNajmabadi