Skip to content

Add note for issue 51692 to source generator cookbooks#76818

Merged
jcouv merged 2 commits into
dotnet:mainfrom
jcracknell:cookbook-note-51692
Feb 17, 2026
Merged

Add note for issue 51692 to source generator cookbooks#76818
jcouv merged 2 commits into
dotnet:mainfrom
jcracknell:cookbook-note-51692

Conversation

@jcracknell

Copy link
Copy Markdown
Contributor

Adds notes to the source generator cookbooks documenting issue #51692, where CompilerVisibleProperty values provided to source generators are lost/damaged in transport as a result of being dumped verbatim into an INI file.

@ghost ghost added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 20, 2025
@dotnet-policy-service dotnet-policy-service Bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Jan 20, 2025
@jcracknell

Copy link
Copy Markdown
Contributor Author

@dotnet-policy-service agree

Adds notes to the source generator cookbooks documenting issue dotnet#51692,
where CompilerVisibleProperty values provided to source generators are
lost/damaged in transport as a result of being dumped verbatim into an
INI file.
@jcouv jcouv requested a review from chsienki February 4, 2025 22:00
@jcouv

jcouv commented Mar 11, 2025

Copy link
Copy Markdown
Member

Tagging @chsienki for review. Thanks

Comment thread docs/features/incremental-generators.cookbook.md Outdated
Comment thread docs/features/source-generators.cookbook.md Outdated
Co-authored-by: Chris Sienkiewicz <chsienki@microsoft.com>
@jcouv jcouv self-assigned this Feb 17, 2026

@jcouv jcouv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (commit 2)

@jcouv jcouv merged commit ac64fa8 into dotnet:main Feb 17, 2026
3 of 4 checks passed
@dotnet-policy-service dotnet-policy-service Bot added this to the Next milestone Feb 17, 2026
@jcouv

jcouv commented Feb 17, 2026

Copy link
Copy Markdown
Member

Sorry for the delay. Merged/squashed. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants