Add support for extract method in the PrimaryConstructor base list#76371
Merged
CyrusNajmabadi merged 6 commits intodotnet:mainfrom Dec 12, 2024
Merged
Add support for extract method in the PrimaryConstructor base list#76371CyrusNajmabadi merged 6 commits intodotnet:mainfrom
CyrusNajmabadi merged 6 commits intodotnet:mainfrom
Conversation
CyrusNajmabadi
commented
Dec 11, 2024
| => false; | ||
|
|
||
| protected override bool IsInPrimaryConstructorBaseType() | ||
| => this.SelectionResult.GetContainingScopeOf<PrimaryConstructorBaseTypeSyntax>() != null; |
Contributor
Author
There was a problem hiding this comment.
the majority of the pr is just updating all the places in EM that special case certain locations to now special case PrimaryConstructorBaseTypeSyntax as well.
Contributor
Author
|
@JoeRobich @ToddGrun @akhera99 ptal. |
1 similar comment
Contributor
Author
|
@JoeRobich @ToddGrun @akhera99 ptal. |
JoeRobich
approved these changes
Dec 12, 2024
This was referenced Dec 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67017