Fix go-to-def on an abstract explicit impl of an interface method#76238
Merged
CyrusNajmabadi merged 5 commits intodotnet:mainfrom Dec 6, 2024
Merged
Fix go-to-def on an abstract explicit impl of an interface method#76238CyrusNajmabadi merged 5 commits intodotnet:mainfrom
CyrusNajmabadi merged 5 commits intodotnet:mainfrom
Conversation
Contributor
Author
|
@ToddGrun ptal |
ToddGrun
reviewed
Dec 6, 2024
| { | ||
| await TestMissingAsync( | ||
| """ | ||
| await TestInRegularAndScriptAsync(""" |
Contributor
Contributor
Author
There was a problem hiding this comment.
Good point. Well fix in follow-up. The original tray was just validating no crash. The actual behavior is fine either way.
This was referenced Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61268