Fix parameters not showing up in 'nameof' on a method#76017
Merged
CyrusNajmabadi merged 2 commits intodotnet:mainfrom Nov 25, 2024
Merged
Fix parameters not showing up in 'nameof' on a method#76017CyrusNajmabadi merged 2 commits intodotnet:mainfrom
CyrusNajmabadi merged 2 commits intodotnet:mainfrom
Conversation
Contributor
Author
|
@genlu ptal |
ToddGrun
reviewed
Nov 25, 2024
| ? null | ||
| : semanticModel.GetSymbolInfo(enclosingMethodOrLambdaNode).GetAnySymbol() ?? semanticModel.GetDeclaredSymbol(enclosingMethodOrLambdaNode); | ||
| if (enclosingMethodOrLambda is IMethodSymbol method) | ||
| symbols = [.. symbols.Concat(method.Parameters)]; |
Contributor
Contributor
Author
There was a problem hiding this comment.
likely yes. will fixup.
Contributor
Author
There was a problem hiding this comment.
no. .Concat returns an IEnumerqable here.
Contributor
There was a problem hiding this comment.
That's confusing. symbols is an IA, method.Parameters is an IA, isn't this invoking the IA overload for Concat?
Contributor
Author
There was a problem hiding this comment.
no, it's not. i get an error when i try :)
Contributor
There was a problem hiding this comment.
oh, I see. One is IA, the other is IA. It needs to be:
symbols.Concat(method.Parameters.Cast());
Contributor
There was a problem hiding this comment.
oh, just a sec, I thought that cast call just cast the array, not enumerate
Contributor
There was a problem hiding this comment.
Duh, it's CastArray, not Cast
This was referenced Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60812