Skip to content

Better Collection Expression Conversion From Expression#74993

Merged
333fred merged 24 commits intodotnet:mainfrom
333fred:feature/bcfce
Sep 20, 2024
Merged

Better Collection Expression Conversion From Expression#74993
333fred merged 24 commits intodotnet:mainfrom
333fred:feature/bcfce

Conversation

@333fred
Copy link
Member

@333fred 333fred commented Sep 4, 2024 •
edited by jcouv
Loading

@ghost ghost added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 4, 2024
@jaredpar jaredpar added this to the 17.12 milestone Sep 5, 2024
@333fred 333fred marked this pull request as ready for review September 10, 2024 17:13
@333fred 333fred requested a review from a team as a code owner September 10, 2024 17:13
@333fred
Copy link
Member Author

333fred commented Sep 10, 2024

@cston, @AlekseyTs for review. I've been able to successfully compile the BCL with no regressions; still working on VS, I've had a few infra issues during previous attempts.

@333fred 333fred requested review from AlekseyTs and cston September 10, 2024 17:16
@AlekseyTs
Copy link
Contributor

AlekseyTs commented Sep 13, 2024

Done with review pass (commit 19)

@333fred
Copy link
Member Author

333fred commented Sep 16, 2024

@AlekseyTs addressed feedback.

AlekseyTs
AlekseyTs approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 20)

@333fred 333fred enabled auto-merge (squash) September 20, 2024 20:54
@333fred 333fred merged commit 433ae40 into dotnet:main Sep 20, 2024
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 17.12, Next Sep 20, 2024
@333fred 333fred deleted the feature/bcfce branch September 20, 2024 22:13
This was referenced Sep 23, 2024
Closed
Closed
@akhera99 akhera99 modified the milestones: Next, 17.12 P3 Sep 26, 2024
@dotnet-bot dotnet-bot mentioned this pull request Oct 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcouv jcouv jcouv left review comments

@AlekseyTs AlekseyTs AlekseyTs approved these changes

+1 more reviewer

@cston cston cston approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Compilers Feature - Collection Expressions Feature - ParamsCollections untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Milestone

17.12 P3

Development

Successfully merging this pull request may close these issues.

6 participants

@333fred @AlekseyTs @cston @jcouv @jaredpar @akhera99