Merged
Conversation
333fred
approved these changes
Jul 1, 2024
RikkiGibson
reviewed
Jul 1, 2024
RikkiGibson
reviewed
Jul 1, 2024
| [Fact] | ||
| public void TestEscapeInInterpolatedSimpleString_E_Preview() | ||
| => Test("$\"\\e\"", @"['\u001B',[2,4]]", CSharpParseOptions.Default.WithLanguageVersion(LanguageVersion.Preview)); | ||
| => Test("$\"\\e\"", @"['\u001B',[2,4]]"); |
Member
There was a problem hiding this comment.
It feels reasonable to update these tests by using LanguageVersion.CSharp12 for the failure case and CSharp13 for the success case, and renaming the tests accordingly
RikkiGibson
approved these changes
Jul 1, 2024
Co-authored-by: Rikki Gibson <rikkigibson@gmail.com>
CyrusNajmabadi
approved these changes
Jul 2, 2024
|
Does this mean that the remaining features will be updated in C# 14? |
Member
Author
|
@SystematicChaos012 No, there are a few more feature that we're still working on but expect to make it into C# 13. |
This was referenced Jul 4, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinged Lee and Rahul by email to update releases.json
Update: the releases.json change should be made around the RC1 for new SDK. Here's the corresponding change: https://github.com/dotnet/core/blob/125ce0692fdf14e4258300b8ed01a24f90235fa1/release-notes/9.0/preview/rc1/release.json#L124