Report diagnostic for field and value in property accessors when used as primary expressions only#74164
Merged
cston merged 2 commits intodotnet:mainfrom Jun 27, 2024
Merged
Conversation
36d1f89 to
ce4478c
Compare
333fred
approved these changes
Jun 26, 2024
RikkiGibson
approved these changes
Jun 27, 2024
This was referenced Jul 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report a diagnostic for
fieldandvaluein contexts where the identifiers will be treated as keywords in a later language version and where the meaning will change as a result.This modifies the earlier change from #73570 to only report a diagnostic when the identifier is a primary expression, since it is assumed the parser will only treat
fieldandvalueas keywords in those cases.