Rename Tools/Options inline hint settings#71855
Rename Tools/Options inline hint settings#71855MariaSolOs wants to merge 2 commits intodotnet:mainfrom
Conversation
|
Thanks! |
dibarbet
left a comment
There was a problem hiding this comment.
cc @mikadumont in case we have any docs that need updating somewhere?
Head branch was pushed to by a user without write access
1470cd1 to
3313139
Compare
|
Keyword search in Tools/Options should work with both "inline" and "inlay" now. |
|
@CyrusNajmabadi can we get this merged? We are adding some settings related to LSP Inlay Hints and we'd like to get this terminology consistent across the different languages. |
|
@sayedihashimi conflicts would need to be resolved. This has been signed off on already. |
Thanks, we will get those resolved soon. |
|
Merge conflicts should be fixed now. @CyrusNajmabadi @jasonmalinowski could one of you verify the changes locally though? I'm having some issues building Roslyn locally because my local VS setup is slightly messed up |
|
My preference is that we also rename the types here. But that can happen later. |
| @@ -92,10 +92,10 @@ Namespace Microsoft.VisualStudio.LanguageServices.VisualBasic.Options | |||
| ServicesVSResources.Color_hints | |||
|
|
|||
| Public ReadOnly Property Option_Inline_Hints As String = | |||
There was a problem hiding this comment.
In the C# options page you also updated the names of these properties. I think it is fine to leave as is, since we plan to rename the types to match. Just need to include this in the tracking issue for the follow up work.
For consistency with LSP and VS Code, renaming user visible strings to use "inlay hints" instead of "inline hints".
I'm willing to also rename the code, but it will be a chunky PR...