Skip to content

Conversation

@MiYanni
Copy link
Member

@MiYanni MiYanni commented Nov 15, 2023

Related: dotnet/sdk#33126

Summary

This is a coordinated update for dotnet/command-line-api in the repos that DARC flows to. There needs to be only 1 version of this dependency for Source Build to function properly.

@MiYanni MiYanni requested a review from a team as a code owner November 15, 2023 02:23
@ghost ghost added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Nov 15, 2023
@jasonmalinowski
Copy link
Member

Isn't this something a bot should be doing automatically?

@MiYanni
Copy link
Member Author

MiYanni commented Nov 15, 2023

@jasonmalinowski

Isn't this something a bot should be doing automatically?

I went and double checked the DARC subscriptions. It definitely should be automatic for this repo...

image

It is enabled, so I'm not sure why it isn't flowing properly. Even the last update to this dependency was also manual via this PR: #68549

@MiYanni
Copy link
Member Author

MiYanni commented Nov 15, 2023

Looks like the integration test failures is a known (and currently being addressed) issue.

@MiYanni
Copy link
Member Author

MiYanni commented Nov 20, 2023

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 70817 in repo dotnet/roslyn

@MiYanni
Copy link
Member Author

MiYanni commented Nov 21, 2023

@jasonmalinowski @jjonescz Are integration tests just being skipped now? I looked a few other PRs to main and they don't run them.

@jasonmalinowski
Copy link
Member

@MiYanni They should all be running after #70872 was merged.

@MiYanni
Copy link
Member Author

MiYanni commented Nov 23, 2023

@jjonescz @jasonmalinowski This now can be merged immediately. The SDK PR and Runtime PR have been merged.

@jjonescz jjonescz merged commit 05b5b59 into dotnet:main Nov 23, 2023
@ghost ghost added this to the Next milestone Nov 23, 2023
@RikkiGibson RikkiGibson modified the milestones: Next, 17.9 P2 Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants