Add support for \e escape sequences in c# strings and characters#70497
Merged
CyrusNajmabadi merged 14 commits intodotnet:mainfrom Oct 27, 2023
Merged
Add support for \e escape sequences in c# strings and characters#70497CyrusNajmabadi merged 14 commits intodotnet:mainfrom
CyrusNajmabadi merged 14 commits intodotnet:mainfrom
Conversation
CyrusNajmabadi
commented
Oct 20, 2023
| case '0': ch = '\0'; break; | ||
| case 'a': ch = '\a'; break; | ||
| case 'b': ch = '\b'; break; | ||
| case 'e': ch = '\u001b'; break; |
Contributor
Author
There was a problem hiding this comment.
will add IDE tests as well. But just wanted to get the ball rolling on this.
Member
|
Don't forget to update language feature status.md |
jcouv
reviewed
Oct 20, 2023
| "\e" | ||
| """; | ||
| var value = "\u001b"; | ||
| var token = LexToken(text, TestOptions.RegularPreview); |
Member
There was a problem hiding this comment.
RegularPreview is the default. I think you intend to test using RegularNext, which will be updated mechanically to Regular13 once it becomes available. #Closed
Contributor
Author
There was a problem hiding this comment.
done. thanks!
CyrusNajmabadi
commented
Oct 22, 2023
src/Compilers/CSharp/Test/Syntax/LexicalAndXml/LexicalErrorTests.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
Oct 22, 2023
src/Compilers/CSharp/Test/Syntax/LexicalAndXml/LexicalErrorTests.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
Oct 22, 2023
src/Compilers/CSharp/Test/Syntax/LexicalAndXml/LexicalErrorTests.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
Oct 22, 2023
CyrusNajmabadi
commented
Oct 22, 2023
3 tasks
jcouv
reviewed
Oct 23, 2023
docs/Language Feature Status.md
Outdated
| | [Params Span\<T> + Stackalloc any array type](https://github.com/dotnet/csharplang/issues/1757) | [params-span](https://github.com/dotnet/roslyn/tree/features/params-span) | [In Progress](https://github.com/dotnet/roslyn/issues/57049) | [cston](https://github.com/cston) | TBD | | [jaredpar](https://github.com/jaredpar) | | ||
| | [Default in deconstruction](https://github.com/dotnet/roslyn/pull/25562) | [decon-default](https://github.com/dotnet/roslyn/tree/features/decon-default) | [In Progress](https://github.com/dotnet/roslyn/issues/25559) | [jcouv](https://github.com/jcouv) | [gafter](https://github.com/gafter) | | [jcouv](https://github.com/jcouv) | | ||
| | [Roles/Extensions](https://github.com/dotnet/csharplang/issues/5497) | [roles](https://github.com/dotnet/roslyn/tree/features/roles) | [In Progress](https://github.com/dotnet/roslyn/issues/66722) | [jcouv](https://github.com/jcouv) | [AlekseyTs](https://github.com/AlekseyTs), [jjonescz](https://github.com/jjonescz) | | [MadsTorgersen](https://github.com/MadsTorgersen) | | ||
| | [Escape character](https://github.com/dotnet/csharplang/issues/7400) | N/A | [In Progress](https://github.com/dotnet/roslyn/pull/70497) | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) | | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) | |
Member
There was a problem hiding this comment.
Put whoever reviews as reviewers (me and someone else)
Contributor
Author
There was a problem hiding this comment.
will do. when i get a second reviewer :)
jcouv
approved these changes
Oct 23, 2023
Member
jcouv
left a comment
There was a problem hiding this comment.
Compiler side LGTM Thanks (iteration 6)
CyrusNajmabadi
commented
Oct 23, 2023
Contributor
Author
|
@dotnet/roslyn-compiler @jaredpar for another set of eyes. |
CyrusNajmabadi
commented
Oct 23, 2023
Contributor
Author
|
@dotnet/roslyn-compiler @RikkiGibson can i get a set of eyes on this small change? thanks! |
RikkiGibson
approved these changes
Oct 24, 2023
CyrusNajmabadi
commented
Oct 24, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Language feature approved by the LDM for the any-time bucket: dotnet/csharplang#7400