Add Primary Constructor tests for some scenarios from Test Plan#70026
Merged
AlekseyTs merged 2 commits intodotnet:mainfrom Sep 20, 2023
Merged
Add Primary Constructor tests for some scenarios from Test Plan#70026AlekseyTs merged 2 commits intodotnet:mainfrom
AlekseyTs merged 2 commits intodotnet:mainfrom
Conversation
jjonescz
approved these changes
Sep 20, 2023
src/Compilers/CSharp/Test/Semantic/Semantics/PrimaryConstructorTests.cs
Outdated
Show resolved
Hide resolved
| // primary constructor parameter, even in field initializers and base clause arguments, we already | ||
| // have pre-existing behavior with records that is not consistent with that. Specifically, primary constructor | ||
| // parameters come first in field initializers and base clause arguments for records. | ||
| // Keeping this behavior for now. |
Member
There was a problem hiding this comment.
Perhaps worth mentioning this in the speclet?
Contributor
Author
There was a problem hiding this comment.
Perhaps worth mentioning this in the speclet?
I am going to bring this as an open design question to LDM.
…rTests.cs Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.