Skip to content

Remove EditorFeatures.Cocoa and VSMac IVTs#69765

Merged
sandyarmstrong merged 1 commit intomainfrom
dev/sandy/adios-cocoa
Sep 1, 2023
Merged

Remove EditorFeatures.Cocoa and VSMac IVTs#69765
sandyarmstrong merged 1 commit intomainfrom
dev/sandy/adios-cocoa

Conversation

@sandyarmstrong
Copy link
Member

@sandyarmstrong sandyarmstrong commented Aug 30, 2023 •
edited by sharwell
Loading

VSMac only needs to be supported on the 17.6 branch now.

Closes #35099

@sandyarmstrong sandyarmstrong requested review from a team as code owners August 30, 2023 17:04
@sandyarmstrong sandyarmstrong requested a review from a team August 30, 2023 17:04
@sandyarmstrong sandyarmstrong requested a review from a team as a code owner August 30, 2023 17:04
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 30, 2023
@build-analysis build-analysis bot mentioned this pull request Aug 30, 2023
Closed
3 tasks
davidwengier
davidwengier approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

dibarbet
dibarbet approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

o7

jasonmalinowski
jasonmalinowski approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@sandyarmstrong
Copy link
Member Author

sandyarmstrong commented Sep 1, 2023

I don't think my changes could have caused this failure, and the test appears to be passing locally, but I can't retrigger jobs so I'm not sure.

[xUnit.net 00:00:54.92] Microsoft.CodeAnalysis.Editor.UnitTests.RenameTracking.RenameTrackingTaggerProviderTests.RenameTrackingSessionContinuesAfterViewingTag [FAIL]
Failed Microsoft.CodeAnalysis.Editor.UnitTests.RenameTracking.RenameTrackingTaggerProviderTests.RenameTrackingSessionContinuesAfterViewingTag [48 ms]
Error Message:
Assert.Equal() Failure
Expected: 1
Actual: 0
Stack Trace:
at Microsoft.CodeAnalysis.Editor.UnitTests.RenameTracking.RenameTrackingTestState.d__27.MoveNext() in /_/src/EditorFeatures/Test/RenameTracking/RenameTrackingTestState.cs:line 190

sharwell
sharwell reviewed Sep 1, 2023
View reviewed changes
@jasonmalinowski
Copy link
Member

jasonmalinowski commented Sep 1, 2023

@sandyarmstrong Not likely, I'll retrigger them.

sharwell
sharwell approved these changes Sep 1, 2023
View reviewed changes
@sandyarmstrong
Remove EditorFeatures.Cocoa and VSMac IVTs
a434b56 
VSMac only needs to be supported on the 17.6 branch now.
@sandyarmstrong
Copy link
Member Author

sandyarmstrong commented Sep 1, 2023

@jasonmalinowski looks good after latest push, can I go ahead and merge?

@jasonmalinowski
Copy link
Member

jasonmalinowski commented Sep 1, 2023

@sandyarmstrong Yep, you're good.

@sandyarmstrong sandyarmstrong merged commit 6acd7e9 into main Sep 1, 2023
@sandyarmstrong sandyarmstrong deleted the dev/sandy/adios-cocoa branch September 1, 2023 20:43
@ghost ghost added this to the Next milestone Sep 1, 2023
@allisonchou allisonchou mentioned this pull request Sep 5, 2023
Closed
@Cosifne Cosifne mentioned this pull request Sep 15, 2023
Merged
@Cosifne Cosifne modified the milestones: Next, 17.8 P3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

@davidwengier davidwengier davidwengier approved these changes

@dibarbet dibarbet dibarbet approved these changes

+1 more reviewer

@sharwell sharwell sharwell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Milestone

17.8 P3

Development

Successfully merging this pull request may close these issues.

Migrate Xamarin IVTs to the External Access pattern

6 participants

@sandyarmstrong @jasonmalinowski @davidwengier @sharwell @dibarbet @Cosifne