Implement support for emitting PrivateImplementationDetails to EnC deltas#69485
Merged
tmat merged 4 commits intodotnet:mainfrom Aug 23, 2023
Merged
Implement support for emitting PrivateImplementationDetails to EnC deltas#69485tmat merged 4 commits intodotnet:mainfrom
tmat merged 4 commits intodotnet:mainfrom
Conversation
61f8408 to
2dd3a65
Compare
Member
Author
|
@davidwengier PTAL |
davidwengier
approved these changes
Aug 14, 2023
Member
davidwengier
left a comment
There was a problem hiding this comment.
Consider getting a compiler review here, as I don't have any context as to implications, but the changes make sense in and of themselves.
Member
Author
|
@dotnet/roslyn-compiler @cston PTAL |
AlekseyTs
reviewed
Aug 14, 2023
src/Compilers/CSharp/Portable/Emitter/EditAndContinue/CSharpSymbolMatcher.cs
Show resolved
Hide resolved
Member
|
@RikkiGibson, @jcouv PTAL |
cston
reviewed
Aug 17, 2023
src/Compilers/CSharp/Portable/Symbols/Synthesized/GeneratedNames.cs
Outdated
Show resolved
Hide resolved
cston
reviewed
Aug 17, 2023
src/Compilers/VisualBasic/Portable/Emit/EditAndContinue/VisualBasicSymbolMatcher.vb
Outdated
Show resolved
Hide resolved
cston
approved these changes
Aug 17, 2023
RikkiGibson
approved these changes
Aug 18, 2023
src/Compilers/Core/CodeAnalysisTest/EditAndContinue/EditAndContinueTest.GenerationVerifier.cs
Outdated
Show resolved
Hide resolved
src/Compilers/Core/CodeAnalysisTest/EditAndContinue/EditAndContinueTest.cs
Show resolved
Hide resolved
src/Compilers/Core/CodeAnalysisTest/EditAndContinue/SemanticEditDescription.cs
Show resolved
Hide resolved
src/Compilers/CSharp/Test/Emit/Emit/EditAndContinue/EditAndContinueTests.cs
Show resolved
Hide resolved
2dd3a65 to
702cd78
Compare
3 tasks
This was referenced Aug 23, 2023
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes support for synthesized inline arrays, inline array helpers and string switch helpers.
We emit new PID type and its contents to each EnC delta. Since PID is not a first-class symbol, this approach is simpler than implementing logic that maps new PID members to the previously emitted ones. We can add the sharing if needed later.
For now, avoid using PID for features that generate FieldRva. In theory, it should work but we need to test it with all supported runtimes. See #69480.
Adds VB implementation of
EditAndContinueTestso that we can use the same test helpers between C# and VB.Fixes #69398