Run ref safety analysis for field initializers on bound nodes transformed to assignments to the target fields.#69088
Merged
AlekseyTs merged 2 commits intodotnet:mainfrom Jul 19, 2023
Conversation
…rmed to assignments to the target fields. Fixes dotnet#67371.
Contributor
Author
|
@cston, @RikkiGibson, @jjonescz, @dotnet/roslyn-compiler Please review. |
RikkiGibson
approved these changes
Jul 18, 2023
| public ref int R3 = ref x; | ||
| } | ||
|
|
||
| ref struct S4([System.Diagnostics.CodeAnalysis.UnscopedRef] ref int x) |
Member
There was a problem hiding this comment.
Should we also have a test for a scoped ref primary constructor parameter which is ref-assigned to ref field in a constructor and in a field initializer?
cston
reviewed
Jul 18, 2023
| "; | ||
| var comp = CreateCompilation(source, options: TestOptions.ReleaseDll, targetFramework: TargetFramework.NetCoreApp); | ||
| comp.VerifyDiagnostics(); | ||
| } |
Contributor
cston
approved these changes
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67371.