EnC: Implement support for editing types with primary constructors#68477
Merged
tmat merged 9 commits intodotnet:mainfrom Jun 26, 2023
Merged
EnC: Implement support for editing types with primary constructors#68477tmat merged 9 commits intodotnet:mainfrom
tmat merged 9 commits intodotnet:mainfrom
Conversation
Member
Author
This might get simpler if we did two passes on the syntactic edits - first identifies what symbols need to be updated and the second can easily check for delete-insert pairs. Will explore that in a follow up. Refers to: src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs:6650 in 9283d26. [](commit_id = 9283d26, deletion_comment = False) |
tmat
commented
Jun 22, 2023
src/Features/Core/Portable/EditAndContinue/EditAndContinueDiagnosticDescriptors.cs
Show resolved
Hide resolved
Member
Author
|
@davidwengier PTAL |
davidwengier
approved these changes
Jun 23, 2023
src/Compilers/CSharp/Test/Emit/Emit/EditAndContinue/EditAndContinueTests.cs
Show resolved
Hide resolved
davidwengier
approved these changes
Jun 23, 2023
Member
Author
|
@dotnet/roslyn-compiler PTAL at compiler tests. |
AlekseyTs
reviewed
Jun 26, 2023
AlekseyTs
reviewed
Jun 26, 2023
AlekseyTs
reviewed
Jun 26, 2023
AlekseyTs
approved these changes
Jun 26, 2023
Contributor
AlekseyTs
left a comment
There was a problem hiding this comment.
Compiler tests LGTM (commit 8), with some comments for new test helpers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables editing types with primary constructors and primary constructors themselves. Enables adding, deleting, renaming and changing types of parameters and switching from primary to non-primary constructor and vice versa.
Fixes various issues with editing record members and implements more unified approach that reduces special casing.
More work is needed to complete the experience and fix issues found during implementation.
Follow up issues: