Skip to content

[main] Update dependencies from dotnet/arcade #67436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jaredpar merged 15 commits into from
May 16, 2023
Merged

[main] Update dependencies from dotnet/arcade #67436

jaredpar merged 15 commits into from
May 16, 2023

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 22, 2023 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 7e4fe80a-482b-4a41-5b66-08d8d8feb47e
  • Build: 20230420.2
  • Date Produced: April 20, 2023 9:13:35 PM UTC
  • Commit: d75baf71a09ed067b48f484f29efc4e7f3e3df13
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
66b4ba3 
…321.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23168.1 -> To Version 8.0.0-beta.23171.2
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner March 22, 2023 12:11
@ghost ghost added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 22, 2023
ghost
ghost approved these changes Mar 22, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approve

dotnet-maestro bot added 11 commits March 23, 2023 12:12
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
a8011b5 
…322.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23168.1 -> To Version 8.0.0-beta.23172.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
4f9966b 
…323.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23168.1 -> To Version 8.0.0-beta.23173.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
8912145 
…324.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23168.1 -> To Version 8.0.0-beta.23174.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
a1560eb 
…327.4

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23168.1 -> To Version 8.0.0-beta.23177.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
bbd8031 
…405.4

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23168.1 -> To Version 8.0.0-beta.23205.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
d8104f7 
…410.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23168.1 -> To Version 8.0.0-beta.23210.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
c5fd82c 
…411.8

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23168.1 -> To Version 8.0.0-beta.23211.8
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
5563777 
…413.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23168.1 -> To Version 8.0.0-beta.23213.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
877e96a 
…417.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23168.1 -> To Version 8.0.0-beta.23217.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
8ff5bb1 
…419.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23168.1 -> To Version 8.0.0-beta.23219.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
3bc0f22 
…420.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23168.1 -> To Version 8.0.0-beta.23220.2
@build-analysis build-analysis bot mentioned this pull request Apr 21, 2023
Open
5 tasks
@jaredpar
Copy link
Member

jaredpar commented May 16, 2023

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented May 16, 2023

Azure Pipelines successfully started running 4 pipeline(s).

@jaredpar jaredpar mentioned this pull request May 16, 2023
Closed
@jaredpar jaredpar requested a review from a team as a code owner May 16, 2023 15:42
cston
cston reviewed May 16, 2023
View reviewed changes
@jaredpar @cston
Update src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenFunctionPointers…
2e9cb4c 
…Tests.cs

Co-authored-by: Charles Stoner <10732005+cston@users.noreply.github.com>
@MichaelSimons
Copy link
Member

MichaelSimons commented May 16, 2023

@oleksandr-didyk, @mmitche - There is a problem with the arcade source-build intermediate. I think what is happening is arcade is compiled against a version of nuget (6.2.2) that is being picked up from SBRP. That SBRP is being loaded for execution which fails.

When prebuilt detection was enabled in SBRP, there was no NuGet intermediate and allowed nuget as a prebuilt as noted here. A few days later the version of nuget referenced by arcade was added to sbrp here. I think the correct fix is to remove the nuget SBRP until we start producing the nuget intermediate. @oleksandr-didyk can you revert your SBRP change to add NuGet 6.2.2?

@oleksandr-didyk
Copy link
Contributor

oleksandr-didyk commented May 16, 2023

@oleksandr-didyk Oleksandr Didyk FTE can you revert your SBRP change to add NuGet 6.2.2?

Sure thing, on it

@oleksandr-didyk oleksandr-didyk mentioned this pull request May 16, 2023
Merged
@oleksandr-didyk
Copy link
Contributor

oleksandr-didyk commented May 16, 2023

@oleksandr-didyk Oleksandr Didyk FTE can you revert your SBRP change to add NuGet 6.2.2?

Sure thing, on it

dotnet/source-build-reference-packages#673 was merged, will trigger the subscription into Arcade once the build is finished

@jaredpar
Copy link
Member

jaredpar commented May 16, 2023

Integration failure is known, merging

@jaredpar jaredpar merged commit ecc3301 into main May 16, 2023
@jaredpar jaredpar deleted the darc-main-4a01f892-a638-4209-867f-2f101beae023 branch May 16, 2023 18:21
@ghost ghost added this to the Next milestone May 16, 2023
@Cosifne Cosifne modified the milestones: Next, 17.7 P2 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@cston cston cston left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Milestone

17.7 P2

Development

Successfully merging this pull request may close these issues.

6 participants

@jaredpar @MichaelSimons @oleksandr-didyk @cston @Cosifne