Is this changing the default here so now even existing tests are evaluated only against PDB and not also against portable PDB as previously? #Closed

Is this changing the default here so now even existing tests are evaluated only against PDB and not also against portable PDB as previously?

That was not my intent and I do not think the default is changed. See the change on the line 369 below.

Why can't we access y here? It's just a field like x, right? #Closed

Why can't we access y here? It's just a field like x, right?

The lambda doesn't have access to the instance because this isn't captured. <>c__DisplayClass0_0 has only x.

internal class C
{
    [CompilerGenerated]
    private sealed class <>c__DisplayClass0_0
    {
        public int x;

        internal int <.ctor>b__0()
        {
            return x;
        }
    }

    [CompilerGenerated]
    private int <y>PC__BackingField;

    [System.Runtime.CompilerServices.Nullable(1)]
    private Func<int> Y;

    public C(int y, int x)
    {
        <y>PC__BackingField = y;
        <>c__DisplayClass0_0 <>c__DisplayClass0_ = new <>c__DisplayClass0_0();
        <>c__DisplayClass0_.x = x;
        Y = new Func<int>(<>c__DisplayClass0_.<.ctor>b__0);
        base..ctor();
    }

    private int M()
    {
        return <y>PC__BackingField;
    }
}

(DisplayClassInstance? Instance, ConsList Fields) possiblyCapturingTypeInstance

Why a tuple rather than two separate parameters? #Resolved

Why a tuple rather than two separate parameters?

The values are closely related and I felt the code is easier to follow this way. At least it was easier to write for me.

shadowingParameterNames.Any((n1, n2) => n1 == n2, parameterName)

Perhaps shadowingParameterNames.Contains(parameterName) #Resolved

&&

Should the check include && !currentFrame.IsStatic? #Resolved

Should the check include && !currentFrame.IsStatic?

I don't think we care if the method itself is static as long as it has a "thisProxy" which can be supplied trough a parameter.

All we care is whether we have access to this by whatever means

PrimaryConstructors_01201_CapturedParameterInsideLocalFunctionInInstanceMethod_WithDisplayClass

How does this test differ from the previous test? Consider adding a comment.

How does this test differ from the previous test? Consider adding a comment.

The difference is in the name of the primary constructor parameter - "value". See the same name used for display class parameter of the frame method - System.Int32 <>x.<>m0(C <>4__this, ref C.<>c__DisplayClass2_0 value)