Skip to content

Correctly emit accessibility when generating properties via SyntaxGenerator#66543

Merged
CyrusNajmabadi merged 5 commits intodotnet:mainfrom
DoctorKrolic:keep-accessor-accessibility
Jan 26, 2023
Merged

Correctly emit accessibility when generating properties via SyntaxGenerator#66543
CyrusNajmabadi merged 5 commits intodotnet:mainfrom
DoctorKrolic:keep-accessor-accessibility

Conversation

@DoctorKrolic
Copy link
Contributor

@DoctorKrolic DoctorKrolic commented Jan 25, 2023

@DoctorKrolic DoctorKrolic requested a review from a team as a code owner January 25, 2023 15:43
@ghost ghost added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Jan 25, 2023
Copy link
Contributor

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DoctorKrolic
Copy link
Contributor Author

@CyrusNajmabadi Restart failed CI pls + automerge

@CyrusNajmabadi CyrusNajmabadi merged commit fe8f333 into dotnet:main Jan 26, 2023
@ghost ghost added this to the Next milestone Jan 26, 2023
@DoctorKrolic DoctorKrolic deleted the keep-accessor-accessibility branch January 26, 2023 10:50
@Cosifne Cosifne modified the milestones: Next, 17.6 P1 Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The SyntaxGenerator omits accessibility level for accessors The SyntaxGenerator omits accessibility level for accessors

3 participants