Port #66241 to Dev17.5#66269
Conversation
|
@arkalyanms we should backport this fix to 17.5. This ensures that a few of our options are properly hooked up to VS' A/B feature testing system. We need this so we can run A/B tests on these in the 17.5 timeframe. If we don't do this, we'd effectively have to wait till 17.6 to test. These options control a few low level workspace behaviors. By default, the behaviors stay the same, but this allows us to tweak the value for a small cohort and see if anything unexpected happens (like high crashes, or more memory being used). If the A/B tests prove out that there are no ill effects, these let us greatly simplify the workspace by removing complexity that has turned out to not be relevant. |
1d87c7a to
6af295f
Compare
| Assert.True(IsOptionValueType(type)); | ||
|
|
||
| if (type == typeof(bool?)) | ||
| return value is null ? true : null; |
There was a problem hiding this comment.
17.6 branch already handled this case, but the code in 17.6 has diverged greatly from 17.5 in these tests. so i just did a spot-change to make things work.
6af295f to
f8f6372
Compare
| Assert.True(IsOptionValueType(type)); | ||
|
|
||
| if (type == typeof(bool?)) | ||
| return value is null ? true : null!; |
There was a problem hiding this comment.
17.6 branch already handled this case, but the code in 17.6 has diverged greatly from 17.5 in these tests. so i just did a spot-change to make things work.
Ports #66241 (Fix a couple of cases where feature options were not being hooked up.) to Dev17.5