workaround tabular data control focus issue#66247
Merged
jmarolf merged 1 commit intodotnet:release/dev17.5from Jan 5, 2023
Merged
workaround tabular data control focus issue#66247jmarolf merged 1 commit intodotnet:release/dev17.5from
jmarolf merged 1 commit intodotnet:release/dev17.5from
Conversation
ryzngard
approved these changes
Jan 4, 2023
Contributor
ryzngard
left a comment
There was a problem hiding this comment.
Approved with small concern
src/VisualStudio/Core/Def/EditorConfigSettings/Common/TableControlFocusFixer.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes ADO#1642253
Without this fix keyboard navigation is inconsistent in the tabular data control.
If you have selected the entire header and not any inner elements (the mouse will select more inner elements) and attempt to collapse the group, your focus will be shifted to the parent control.
With this change we intercept this specific behavior and opt-out of the focus change.