Only get the associated symbol, not the containing symbol#64496
Merged
davidwengier merged 1 commit intodotnet:release/dev17.4from Oct 5, 2022
Merged
Only get the associated symbol, not the containing symbol#64496davidwengier merged 1 commit intodotnet:release/dev17.4from
davidwengier merged 1 commit intodotnet:release/dev17.4from
Conversation
davidwengier
commented
Oct 5, 2022
| return symbol; | ||
| } | ||
|
|
||
| private static ISymbol? GetAssociatedSymbol(ISymbol symbol) |
Member
Author
There was a problem hiding this comment.
The diff on this looks bigger than it is - GetAssociatedSymbol is just a straight "Extract Method" from the above
Member
Author
|
FYI @arkalyanms for 17.4 PR @tmat PTAL |
arunchndr
approved these changes
Oct 5, 2022
|
@dotnet/roslyn-compiler for compiler signoffs. |
333fred
approved these changes
Oct 5, 2022
chsienki
approved these changes
Oct 5, 2022
Member
Author
|
Thanks folks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AB#1632487
We were incorrectly getting the containing symbol for a field, when we only actually want to get the associated symbol.