Use TargetFramework.Net70 instead of RuntimeFlag.ByRefFields in CreateCompilation#64400
Merged
jcouv merged 2 commits intodotnet:mainfrom Sep 30, 2022
Merged
Use TargetFramework.Net70 instead of RuntimeFlag.ByRefFields in CreateCompilation#64400jcouv merged 2 commits intodotnet:mainfrom
TargetFramework.Net70 instead of RuntimeFlag.ByRefFields in CreateCompilation#64400jcouv merged 2 commits intodotnet:mainfrom
Conversation
751ff9a to
4db461f
Compare
333fred
approved these changes
Sep 30, 2022
cston
approved these changes
Sep 30, 2022
AlekseyTs
reviewed
Oct 1, 2022
| { | ||
| Debug.Assert(targetFramework == TargetFramework.Standard || runtimeFeature == RuntimeFlag.None); | ||
| if (runtimeFeature == RuntimeFlag.ByRefFields) | ||
| if (targetFramework == TargetFramework.Net70) |
Contributor
There was a problem hiding this comment.
I actually thought that we would add a set of corresponding ref assemblies, perhaps fake, rather that keeping any special cases in CreateCompilation. This implementation feels fragile because one has to remember removing/adjusting it once real Net70 ref assemblies are added. Otherwise this helper will keep hijacking references. I actually think this is worse than having the runtimeFeature parameter. Given this, at the moment, I would prefer removing this if completely and adding real Net70 ref assemblies.
Member
Author
There was a problem hiding this comment.
Let's discuss after next standup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63223
One commit is a mechanical search&replace. The other updates the test helper.