Add support for code refactorings and code fixes in non-source files#64364
Merged
mavasani merged 28 commits intodotnet:mainfrom Oct 31, 2022
Merged
Add support for code refactorings and code fixes in non-source files#64364mavasani merged 28 commits intodotnet:mainfrom
mavasani merged 28 commits intodotnet:mainfrom
Conversation
Addresses `CodeRefactoring API` portion of dotnet#62877
mavasani
commented
Sep 29, 2022
src/EditorFeatures/Core.Wpf/Suggestions/SuggestedActionsSourceProvider.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
…t until [AB#1639743](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1639743) is fixed dotnet#64567 tracks reverting this commit
mavasani
commented
Oct 7, 2022
mgoertz-msft
approved these changes
Oct 7, 2022
Contributor
mgoertz-msft
left a comment
There was a problem hiding this comment.
This looks great. Thank you for doing this, @mavasani!
I love that you considered the filtering by document extension too. :)
src/Workspaces/TestAnalyzerReference/Microsoft.CodeAnalysis.TestAnalyzerReference.csproj
Show resolved
Hide resolved
src/Workspaces/Core/Portable/CodeRefactorings/ExportCodeRefactoringProviderAttribute.cs
Show resolved
Hide resolved
src/Workspaces/Core/Portable/CodeRefactorings/CodeRefactoringContext.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/IntegrationTest/New.IntegrationTests/AbstractEditorTest.cs
Outdated
Show resolved
Hide resolved
...torFeatures/Core.Wpf/Suggestions/SuggestedActionsSourceProvider.NonSourceDocumentProvider.cs
Outdated
Show resolved
Hide resolved
...torFeatures/Core.Wpf/Suggestions/SuggestedActionsSourceProvider.NonSourceDocumentProvider.cs
Outdated
Show resolved
Hide resolved
…and add the non-source file refactoring to this project
Contributor
Author
|
@jasonmalinowski Thank you for the thorough feedback! I think I have addressed most of it, and create one follow-up work item. I also verified that the added integration test passes after the latest commit if I uncomment out |
Contributor
Author
|
@jasonmalinowski can you take another look when convenient? |
Member
|
@mavasani Apologies for not re-reviewing earlier; I had forgotten I didn't sign off originally. |
…rs `[EditorBrowsable(EditorBrowsableState.Never)]`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses
CodeRefactoring APIandCodeFix APIportion of #62877TODO:
[ContentType("text")]attribute and unskip integration test #64567 tracks uncommenting this attribute once the required Editor support has been added. See CodeFix/CodeRefactoring Support for AdditionalFiles and AnalyzerConfigFiles #62877 (comment) for details.Public APIs added
Code Refactoring API
Code Fix API
Examples
Example code refactoring
Example code fix provider