CSharp.DeclarationTable – avoid realizing lazy roots during add/remove operations.#63517
Merged
AlekseyTs merged 1 commit intodotnet:mainfrom Aug 24, 2022
Merged
CSharp.DeclarationTable – avoid realizing lazy roots during add/remove operations.#63517AlekseyTs merged 1 commit intodotnet:mainfrom
AlekseyTs merged 1 commit intodotnet:mainfrom
Conversation
…e operations. Related to [AB#1436225](https://devdiv.visualstudio.com/0bdbc590-a062-4c3f-b0f6-9383f67865ee/_workitems/edit/1436225).
Contributor
Author
|
This is an alternative for #59392. |
Contributor
Author
|
@sharwell FYI |
CyrusNajmabadi
approved these changes
Aug 22, 2022
Contributor
Author
333fred
approved these changes
Aug 22, 2022
Member
333fred
left a comment
There was a problem hiding this comment.
LGTM (commit 1), as this aligns VB and C#'s implementations. Further optimizations can be applied to both languages as a follow up if needed.
Contributor
Author
|
@dotnet/roslyn-compiler For the second review. |
RikkiGibson
approved these changes
Aug 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to AB#1436225.