Share a DiagnosticAnalyzerInfoCache between DiagnosticAnalyzerService and DiagnosticAnalyzerServiceQuickInfoProvider#63392
Merged
333fred merged 3 commits intodotnet:mainfrom Aug 16, 2022
Conversation
… and DiagnosticAnalyzerServiceQuickInfoProvider In dotnet#60266, the CSharpDiagnosticAnalyzerServiceQuickInfoProvider was moved to the EditorFeatures layer because DiagnosticAnalyzerService was moved to the protocol layer, breaking MEF composition for the provider. This broke the feature in O#, however, and users reported OmniSharp/omnisharp-roslyn#2397. In investigating the service, I realized that the only thing the provider required is the cache from the DiagnosticAnalyzerService, which is a type that exists in the Workspaces layer. To fix this, I'm introducing shared export cache, so both quick info provider and analyzer service can share this instance, while allowing the provider to move back down to the features layer. Fixes OmniSharp/omnisharp-roslyn#2397.
mavasani
approved these changes
Aug 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #60266, the CSharpDiagnosticAnalyzerServiceQuickInfoProvider was moved to the EditorFeatures layer because DiagnosticAnalyzerService was moved to the protocol layer, breaking MEF composition for the provider. This broke the feature in O#, however, and users reported OmniSharp/omnisharp-roslyn#2397. In investigating the service, I realized that the only thing the provider required is the cache from the DiagnosticAnalyzerService, which is a type that exists in the Workspaces layer. To fix this, I'm introducing shared export cache, so both quick info provider and analyzer service can share this instance, while allowing the provider to move back down to the features layer. Fixes OmniSharp/omnisharp-roslyn#2397.
For ease of review, I've split this into two commits. The first commit does the shared cache refactoring, and leaves the files in place. The second commit moves the files, and does not touch their contents.