Install a .NET 6 runtime for the MSBuild Workspace unit tests.#63369
Install a .NET 6 runtime for the MSBuild Workspace unit tests.#63369
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
1 similar comment
This comment was marked as off-topic.
This comment was marked as off-topic.
| steps: | ||
| - checkout: none | ||
|
|
||
| # A .NET 6 runtime is needed since our unit tests target net6.0 |
There was a problem hiding this comment.
Should we just be upgrading to something newer here?
There was a problem hiding this comment.
We could update our tests to target net7.0, but that seems like a more disruptive change. In the scheme of things the SingleMachine CI jobs aren't strictly necessary and may not be providing value over the Helix CI. They were mainly intended to ensure our infra changes didn't break the ability to run tests locally.
There was a problem hiding this comment.
FWIW i was chatting with @dibarbet about this the other day.
They were mainly intended to ensure our infra changes didn't break the ability to run tests locally.
Exactly. More broadly it was to make sure that we had some sanity check in place to make sure people could develop locally: build, test and run. We lost that to a large extent when we moved to Helix. The single machine tests exists to make sure we can develop locally.
That means we don't even need to run all tests here. We just need to run enough that we're convinced we haven't broken things.
Windows CoreCLR Single Machine job test run: https://dev.azure.com/dnceng/public/_build/results?buildId=1941171&view=results