Revert "Merge pull request #61568 from CyrusNajmabadi/localFuncindexing"#63344
Merged
JoeRobich merged 1 commit intodotnet:release/dev17.3from Aug 12, 2022
Merged
Conversation
genlu
approved these changes
Aug 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit b1fbb44, reversing
changes made to d79fe4e.
Confirmed this is the cause of many of the servicehub crashes in https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1582837
This typically occurs in generated files with large binary expressions. Note that VS crashes when you actually open these files, but before this change as long as the file wasn't opened everything else used to work.
There are a bunch of other places to change to fix VS crashing on open files (@Cosifne is tracking them down), but those bugs existed before 17.3. This revert resolves the only known case where we crash servicehub when the file is not opened.