Skip to content

EnC: Log deltas and messages to disk#63269

Merged
tmat merged 3 commits intodotnet:mainfrom
tmat:EncFileLoggingMain
Aug 9, 2022
Merged

EnC: Log deltas and messages to disk#63269
tmat merged 3 commits intodotnet:mainfrom
tmat:EncFileLoggingMain

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented Aug 8, 2022

No description provided.

@tmat tmat requested a review from a team as a code owner August 8, 2022 22:02
@ghost ghost added the Area-Interactive label Aug 8, 2022
Copy link
Copy Markdown
Member

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if a boolean env var would be easier... we can find the temp folder, append a datetime to the path maybe? Means you could just leave this it turned on potentially.

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Aug 9, 2022

I wonder if a boolean env var would be easier... we can find the temp folder, append a datetime to the path maybe? Means you could just leave this it turned on potentially.

IDK, sounds like leaving it on would make it easy to create a lot of useless files by accident. We'd also need to include VS instance id to avoid multiple VS instances to overwrite each others files.

@tmat tmat force-pushed the EncFileLoggingMain branch from 127aacd to 0bf9ce6 Compare August 9, 2022 18:28
@tmat
Copy link
Copy Markdown
Member Author

tmat commented Aug 9, 2022

Perhaps we could delete the content of the directory at the start of the first session? That way you can keep it turned on but it will not produced unbounded amount of files.

@dibarbet
Copy link
Copy Markdown
Member

dibarbet commented Aug 9, 2022

I wonder if a boolean env var would be easier... we can find the temp folder, append a datetime to the path maybe? Means you could just leave this it turned on potentially.

IDK, sounds like leaving it on would make it easy to create a lot of useless files by accident. We'd also need to include VS instance id to avoid multiple VS instances to overwrite each others files.

Should this logging use loghub? Then we don't have to worry about deletion or file size or file names really and they would get uploaded to feedback tickets

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Aug 9, 2022

Should this logging use loghub?

Does loghub support logging binary data (potentially large files)?

@dibarbet
Copy link
Copy Markdown
Member

dibarbet commented Aug 9, 2022

Ah good question, not quite sure. It just gives back a TraceSource, don't know if it'll handle binary data
https://sourceroslyn.io/#Microsoft.VisualStudio.LanguageServices/LanguageClient/VisualStudioLogHubLoggerFactory.cs,67

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Aug 9, 2022

I don't think LogHub is suitable for this kind of logging.

@dibarbet
Copy link
Copy Markdown
Member

dibarbet commented Aug 9, 2022

I don't think LogHub is suitable for this kind of logging.

Sounds good - just wanted to check in case it would be useful!

@davidwengier
Copy link
Copy Markdown
Member

Happy to leave it like this for now and see how it goes too :)

@tmat tmat merged commit dce4c6f into dotnet:main Aug 9, 2022
@tmat tmat deleted the EncFileLoggingMain branch August 9, 2022 23:16
@ghost ghost added this to the Next milestone Aug 9, 2022
@dibarbet dibarbet modified the milestones: Next, 17.4 P2 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants