EnC: Log deltas and messages to disk#63269
Conversation
davidwengier
left a comment
There was a problem hiding this comment.
I wonder if a boolean env var would be easier... we can find the temp folder, append a datetime to the path maybe? Means you could just leave this it turned on potentially.
src/Features/Core/Portable/EditAndContinue/EditAndContinueWorkspaceService.cs
Show resolved
Hide resolved
IDK, sounds like leaving it on would make it easy to create a lot of useless files by accident. We'd also need to include VS instance id to avoid multiple VS instances to overwrite each others files. |
127aacd to
0bf9ce6
Compare
|
Perhaps we could delete the content of the directory at the start of the first session? That way you can keep it turned on but it will not produced unbounded amount of files. |
Should this logging use loghub? Then we don't have to worry about deletion or file size or file names really and they would get uploaded to feedback tickets |
Does loghub support logging binary data (potentially large files)? |
|
Ah good question, not quite sure. It just gives back a TraceSource, don't know if it'll handle binary data |
|
I don't think LogHub is suitable for this kind of logging. |
Sounds good - just wanted to check in case it would be useful! |
|
Happy to leave it like this for now and see how it goes too :) |
No description provided.