@tmat this is ready for review.

@roslyn-ide @jasonmalinowski ptal. thanks!

LGTM. I'm wondering why do we have this namespace at all though. It's not very specific, other namespaces also contain language services.

yeah. i think we just placed them there to keep them somewhere. but i would actually have no problem being in Microsoft.CodeAnalysis.

@CyrusNajmabadi @333fred this appears to break anyone who references public types like https://github.com/dotnet/roslyn/blob/main/src/VisualStudio/Core/Def/ProjectSystem/VisualStudioWorkspace.cs#L22 via LanguageServices.VisualStudioWorkspace. Found this in a VS insertion. Should be easy enough to fix, but wanted to check if that was intentional.

Hrmm... That's interesting. So they have a using for Microsoft.CodeAnalysis.Host as well?

So they have a using for Microsoft.CodeAnalysis.Host as well?

Yes

Yeah specifically see this commit - https://devdiv.visualstudio.com/DevDiv/_git/VS/commit/5e5e6d1bbfe272b86625b3fef2fbad65d1155a46?refName=refs%2Fheads%2Fdev%2Fvslsnap%2Finsertions%2Fmain.20220812045626

Yeah, this will be an unfortunate, but rarely-hit source-break. Binary compat is still there. Can happen when there are common names in disparate namespaces, and multiple usings. This can happen within a component, or across components unfortunately,